Code Monkey home page Code Monkey logo

Comments (6)

stephen-hill avatar stephen-hill commented on June 9, 2024

Alternatively, #40 is a good compromise because it allows develops to write complicated rules within the closure.

from aura.input.

stephen-hill avatar stephen-hill commented on June 9, 2024

Another idea to add to the discussion is to allow the addition of some sort of AdvancedFilter class which can be allowed to have a range of methods such as:

  • addRule($field, $message, $closure)
  • setRequired($field, $message)
  • mustBeEmail($field, $message)
  • etc.

from aura.input.

stephen-hill avatar stephen-hill commented on June 9, 2024

So for the time being, I've written my own class which extends Filter and implements an addRule() method and a re-written values() method which handles multiple rules per field.

Would you seriously consider the addition of this additional class if I created a pull-request?

This will solve the problem of #39, and I could also merge in #40 too. So the original Filter class is left untouched but gives developers the option of using this new class which provides some extra functionality.

I'm using this library in a large application and would prefer to give back to the community, rather than keeping my own branch/fork. So I'm very happy to put in the work for some kind of solution or compromise.

Many Thanks
Stephen

from aura.input.

pmjones avatar pmjones commented on June 9, 2024

Would you seriously consider the addition of this additional class if I created a pull-request?

Sure, let's see the PR.

And thanks for doing the work!

from aura.input.

pmjones avatar pmjones commented on June 9, 2024

I think this is taken care of now that #40 is merged. Let me know if there's still trouble.

from aura.input.

stephen-hill avatar stephen-hill commented on June 9, 2024

Thanks Paul. #40 definitely achieves the same end result :)

from aura.input.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.