Comments (6)
Alternatively, #40 is a good compromise because it allows develops to write complicated rules within the closure.
from aura.input.
Another idea to add to the discussion is to allow the addition of some sort of AdvancedFilter
class which can be allowed to have a range of methods such as:
- addRule($field, $message, $closure)
- setRequired($field, $message)
- mustBeEmail($field, $message)
- etc.
from aura.input.
So for the time being, I've written my own class which extends Filter
and implements an addRule()
method and a re-written values()
method which handles multiple rules per field.
Would you seriously consider the addition of this additional class if I created a pull-request?
This will solve the problem of #39, and I could also merge in #40 too. So the original Filter
class is left untouched but gives developers the option of using this new class which provides some extra functionality.
I'm using this library in a large application and would prefer to give back to the community, rather than keeping my own branch/fork. So I'm very happy to put in the work for some kind of solution or compromise.
Many Thanks
Stephen
from aura.input.
Would you seriously consider the addition of this additional class if I created a pull-request?
Sure, let's see the PR.
And thanks for doing the work!
from aura.input.
I think this is taken care of now that #40 is merged. Let me know if there's still trouble.
from aura.input.
Thanks Paul. #40 definitely achieves the same end result :)
from aura.input.
Related Issues (20)
- What about automatic id HOT 5
- GetItrator() throw NoSuchInput exception
- Packagist "dev-develop" refference is not updated. HOT 1
- FormFactory HOT 5
- There should be a way to set error messages for the field
- getValues HOT 2
- Need hasField HOT 4
- When there is post value for csrf token HOT 2
- Fieldsets and collections HOT 12
- Add an empty row to the collection HOT 6
- 1.1.1 missing the extra in composer.json HOT 1
- May be a isSuccess flag HOT 6
- Delete form and initial branch?
- Re: An addR HOT 1
- Starting 3.x HOT 11
- [Bug] Form missed to filter for Collection and Fieldset HOT 1
- On integrating Filter and Input. Are we sure? HOT 6
- Why no setOptions on Fieldset? HOT 3
- What is the future of this project? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aura.input.