Code Monkey home page Code Monkey logo

Comments (9)

dustinboston avatar dustinboston commented on August 19, 2024

@addyosmani That's a good point about the end-user specifying the fallbacks.

The problem with the current approach is that the error doesn't get triggered in IE 6-8. See IE load issues.

An unknown for me is whether errbacks work with almond.

I recently added errbacks to a project at work. The big caveat is that you can't use "require" in the bootstrap. It has to be a define. Honestly I'm really not confident about either solution, but I think it's a problem that definitely needs to be resolved.

Do you have any insight?

from aura.

addyosmani avatar addyosmani commented on August 19, 2024

@jrburke do you happen to know if the RequireJS errbacks work with Almond? :)

@dustinboston If the current approach has cross-browser issues we should definitely opt for the prescribed way of doing errbacks. It shouldn't be too hard a switch.

from aura.

dustinboston avatar dustinboston commented on August 19, 2024

@addyosmani It's pretty straightforward. I'll be working on Aura tonight so I'll get the errbacks in first.

from aura.

jrburke avatar jrburke commented on August 19, 2024

@addyosmani almond does not support errbacks, in that it does not call them (it is assumed that all modules are available, it cannot dynamically load from the network). But if you pass almond some errbacks it should not blow up, it just will not call them.

from aura.

addyosmani avatar addyosmani commented on August 19, 2024

@jrburke Thanks for letting us know. I appreciate the confirmation about almond's errback support. It's useful to know that if we do choose to use Almond, nothing should go haywire if we use errbacks :)

from aura.

dustinboston avatar dustinboston commented on August 19, 2024

@jrburke Thank you

from aura.

dustinboston avatar dustinboston commented on August 19, 2024

@addyosmani errbacks are done. @joelhooks heads up, the widget path is throwing an error in the tests. I started a method to help the tests get the correct path, but architecturally I don't think it will work. (getWidgetsPath). Marking this as closed unless there's anything else that needs to be done.

from aura.

jrburke avatar jrburke commented on August 19, 2024

Just a heads up, I discovered a bug with almond and the use of errbacks, but fixed it, so be sure to grab almond 0.1.3 or later if you want code with errbacks to not err out with almond.

from aura.

addyosmani avatar addyosmani commented on August 19, 2024

Thanks for the heads up, James!

from aura.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.