Code Monkey home page Code Monkey logo

Comments (33)

aunetx avatar aunetx commented on May 22, 2024 1

Glad it works for you too :)
And sorry for v12, I did not thinks about it... Will do it tomorrow, when I am on my computer ^^

from blur-my-shell.

aunetx avatar aunetx commented on May 22, 2024

Could you give me the result of typing Main.panel.width in looking glass (alt+f2, type lg)?
And the result of Main.layoutManager.primaryMonitor.width too, so I make sure I change the right thing

from blur-my-shell.

aunetx avatar aunetx commented on May 22, 2024

Last commits should have fixed this, but if not then please tell it to me :)

from blur-my-shell.

Caliel666 avatar Caliel666 commented on May 22, 2024

hello, here's the outputs

image

and last commit didn't do anything, i even tried to change some things in panel.js (140-151) to the exact width and height of my resolution and nothing happened

also changing this.monitor.width to Main.layoutManager.primaryMonitor.width in panel.js didn't change anything

from blur-my-shell.

aunetx avatar aunetx commented on May 22, 2024

Oh ok, that's a much worse bug than I though... Does your wallpaper resolution match (or exceed) your monitor resolution?
It looks like you are using a 1080p wallpaper, and so when cloning it, the extension does not extend it so it matches the right resolution

from blur-my-shell.

aunetx avatar aunetx commented on May 22, 2024

I mean, I think, because I can't reproduce this on my machine...

from blur-my-shell.

aunetx avatar aunetx commented on May 22, 2024

In looking glass, could you tell me the result of those commands:

Main.panel.get_parent().get_child_at_index(0).width
Main.panel.get_parent().get_child_at_index(0).get_child_at_index(0).width

And maybe try these commands, to see if it changes anything:

Main.panel.get_parent().get_child_at_index(0).set_x_expand(true)
Main.panel.get_parent().get_child_at_index(0).get_child_at_index(0).set_x_expand(true)

from blur-my-shell.

Caliel666 avatar Caliel666 commented on May 22, 2024

my wallpaper is waaay bigger then my resolution, but even when changing it to a different one doesn't make the panel look correct

outputs:
image

i think the issue is Main.panel.get_parent().get_child_at_index(0).get_child_at_index(0).width

second output:
image

from blur-my-shell.

Caliel666 avatar Caliel666 commented on May 22, 2024

quick update

i found out that having 2 monitors is the issue, the panel looks correct on the 2560 resolution when disabling my second 1080p monitor

from blur-my-shell.

aunetx avatar aunetx commented on May 22, 2024

Sorry for closing, could you try with latest commit?

from blur-my-shell.

aunetx avatar aunetx commented on May 22, 2024

Sorry again, I did an error... Try with new last commit to this day (597eb90) maybe?

from blur-my-shell.

Caliel666 avatar Caliel666 commented on May 22, 2024

it didn't fix it, but since the problem is when having 2 monitors i think this issue can be closed, it's not related for ultrawide monitors

from blur-my-shell.

aunetx avatar aunetx commented on May 22, 2024

Ok thanks, I guess I will need to test my extension some little more...
I let this open, but just change its subject! It's not the same as #40 anyway, so I will need two separate issues

from blur-my-shell.

Caliel666 avatar Caliel666 commented on May 22, 2024

ok!

just to revise the issue, it works perfectly with 2 monitors on a 16:9 resolution, does not work with a 21:9 monitor and a 16:9 dual setup

works perfectly with a single monitor no matter the resolution

from blur-my-shell.

aunetx avatar aunetx commented on May 22, 2024

Ok thanks, will test this soon!
Multi-monitor support is actually quite entertaining :)

from blur-my-shell.

ruathudo avatar ruathudo commented on May 22, 2024

I confirm this issue happen for me too. To reproduce, you need to have 2 monitors with different resolutions. In my case, the panel is blurred half which is exactly the ratio of 2 monitors.

from blur-my-shell.

aunetx avatar aunetx commented on May 22, 2024

Could you give me the results of:

Main.layoutManager.monitors[0].width
Main.panel.get_parent().get_children()[0].get_children()[0].width
Main.panel.get_parent().get_children()[0].get_children()[0].width


Main.layoutManager.monitors[1].width
Main.panel.get_parent().get_children()[0].get_children()[1].width
Main.panel.get_parent().get_children()[0].get_children()[1].width

So I better understand what happens :)

from blur-my-shell.

Caliel666 avatar Caliel666 commented on May 22, 2024

image

from blur-my-shell.

aunetx avatar aunetx commented on May 22, 2024

Thanks a lot, that's perfect :) will look into this

from blur-my-shell.

aunetx avatar aunetx commented on May 22, 2024

Sorry, could you give me the result of Main.layoutManager.primaryMonitor.index too? Just to make sure of one thing

from blur-my-shell.

Caliel666 avatar Caliel666 commented on May 22, 2024

image
there we go

from blur-my-shell.

aunetx avatar aunetx commented on May 22, 2024

Thanks a lot :)

from blur-my-shell.

aunetx avatar aunetx commented on May 22, 2024

Ok, I get it

from blur-my-shell.

aunetx avatar aunetx commented on May 22, 2024

Is this issue fixed with last commit?

from blur-my-shell.

Caliel666 avatar Caliel666 commented on May 22, 2024

yes! static blur now works as intended with different resolutions on multi monitors, well at least on my setup, thank you!

from blur-my-shell.

aunetx avatar aunetx commented on May 22, 2024

Cool! You're welcome, enjoy :)

from blur-my-shell.

guihkx avatar guihkx commented on May 22, 2024

Thank you @aunetx, the fix also worked for me. (2 screens, first one 1920x1080, second one 1360x768)

Any plans to release v12 soon? Thanks :)

from blur-my-shell.

mbrla0 avatar mbrla0 commented on May 22, 2024

This issue doesn't seem to be fixed in the latest master in my setup. It only works properly when my primary monitor, the one with higher resolution, is to the left of the secondary monitor, which has a lower resolution.

If I instead put the secondary monitor to the left of my primary one, the static blur cuts off at a width equal to the width of the secondary monitor.

from blur-my-shell.

aunetx avatar aunetx commented on May 22, 2024

It is pushed to gnome extensions, waiting for review.

@DarkRyu550 could you give me the results of this in looking glass, when the extension has bad behaviour?

Main.layoutManager.monitors[0].x
Main.layoutManager.monitors[0].width
Main.panel.get_parent().get_children()[0].get_children()[0].width
Main.panel.get_parent().get_children()[0].get_children()[0].width

Main.layoutManager.monitors[1].x
Main.layoutManager.monitors[1].width
Main.panel.get_parent().get_children()[0].get_children()[1].width
Main.panel.get_parent().get_children()[0].get_children()[1].width

from blur-my-shell.

mbrla0 avatar mbrla0 commented on May 22, 2024

Here are the results.
image

And how it looks, for reference.
image

from blur-my-shell.

mbrla0 avatar mbrla0 commented on May 22, 2024

I seem to have found the bit of code that is responsible for this issue. I'll open a PR to submit my fix.

from blur-my-shell.

aunetx avatar aunetx commented on May 22, 2024

Thanks a lot!!

from blur-my-shell.

JakWai01 avatar JakWai01 commented on May 22, 2024

I also have an issue with this. My main monitor is a 4k one on the left. I also have a 1920x1080 one on the right. If I move the smaller one to the left it works. If the smaller one is on the right, it doesn't.

from blur-my-shell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.