Support base-href option about ngx-monaco-editor HOT 8 OPEN

Seems that ./assets works too, like @bboehm86 suggested, though not sure why. I'm able to build for gh-pages by using the following import in AppModule:

MonacoEditorModule.forRoot({baseUrl: "./assets"})

from ngx-monaco-editor.

I guess ./assets as default would be ok too 🤔

from ngx-monaco-editor.

Well, if you don't provide --base-href option in ng build --prod, /assets will be used (default behaviour).
This, for example, can help to set npm script to build Angular app for gh-pages and prod (exemple: for Docker) easily without changing code. The other ways is to set env variable for assets path or as i do in my project, retrieve the base-href path used.
I already submitted a PR #64 . It not really a good solution but it works 😕

from ngx-monaco-editor.

I'm facing that problem too.
Any walkaround?

OK, after i wrote that i read @yowari comment once again and i'll try that way. Thanks =)

from ngx-monaco-editor.

this doesn't work for me

from ngx-monaco-editor.

Seems that ./assets works too, like @bboehm86 suggested, though not sure why. I'm able to build for gh-pages by using the following import in AppModule:

MonacoEditorModule.forRoot({baseUrl: "./assets"})

This worked perfectly for me. It should be quoted in the Readme.md in my opinion

from ngx-monaco-editor.

It's doesn't work for me too

from ngx-monaco-editor.

it works fine for me, even with remote URL:

MonacoEditorModule.forRoot({
  baseUrl: 'http://localhost:53015/assets'
})

from ngx-monaco-editor.