Rubocop being run against erbs about linter-rubocop HOT 21 CLOSED

AllCops:
  Exclude:
    - "**/*.erb"

Putting this in .rubocop.yml fixed this issue for me.

from linter-rubocop.

I am experiencing this issue, first time, after upgrading Atom

Software versions:

Ubuntu 18.10
language-ruby: 0.72.14
language-ruby-on-rails: 0.25.3
linter-ruby: 1.2.6
linter-rubocop: 2.2.3
Rubocop: 0.60.0
Atom: 1.32.2

.rubocop.yml

AllCops:
  TargetRubyVersion: 2.3

Metrics/LineLength:
  Max: 100

Style/AsciiComments:
  Enabled: false

from linter-rubocop.

@RonaldDijkstra for me not really option as I share my config with my team :-(

from linter-rubocop.

seems to be an problem with the language-ruby plugin.
same problem like in linter-ruby. AtomLinter/linter-ruby#26

from linter-rubocop.

I think what happened here is that this line prevented rubocop from parsing a .erb file in the old versions:

But after the change the value of the -stdin does not have an effect anymore. So the real issue here is the same as before I guess to make sure a .erb file is not marked as a ruby file

from linter-rubocop.

it happens again 😿

from linter-rubocop.

AllCops:
  Exclude:
    - "**/*.erb"

Putting this in .rubocop.yml fixed this issue for me.

for me not really option as I share my config with my team :-(

You can add it to a personal config file at $HOME/.rubocop.yml that way it won't conflict with your project / team. Not a perfect solution but it's workable work around.

from linter-rubocop.

I also have this Problem but I'm not sure which update introduced it.

from linter-rubocop.

Have this as well. Is it possible to work around until a fix is made available?

from linter-rubocop.

A workaround is to switch the language of the file to HTML (Rails) instead of HTML (Ruby - ERB), and then reopen the file.

from linter-rubocop.

+1

from linter-rubocop.

As mentioned over in AtomLinter/linter-ruby#26 this is a bug in language-ruby, you can try installing language-ruby-on-rails which properly marks embedded ruby code as source.embedded.ruby, which this plugin (correctly) does not mark itself as being able to handle.

I'm marking this as closed since this isn't an issue that can or should be fixed here.

from linter-rubocop.

Filed an issue over there as it seems nobody had bothered to yet 😉.

from linter-rubocop.

@Arcanemagus could this issue be opened again until it's fixed? It seems the requested scope changes were made in atom/language-ruby#114, but the linter still attempts to run against .html.erb files

from linter-rubocop.

@rutgerfarry This issue has been fixed since Atom v1.4.0-beta0. If you are still experiencing this can you file a new issue with the scopes you are seeing when you run Editor: Log Cursor Scopes?

from linter-rubocop.

Me too!

from linter-rubocop.

Same here, happening again with:

Atom 1.33.0
linter 2.2.0
linter-rubocop 2.2.3
language-ruby 0.72.14
language-ruby-on-rails 0.25.3

from linter-rubocop.

Same here:

Atom 1.33.0
linter 2.2.0
linter-erb 1.1.1
linter-rubocop 2.2.3
linter-ruby 1.2.6
language-ruby 0.72.14
language-ruby-on-rails 0.25.3

Can you reopen this issue?

from linter-rubocop.

+1

from linter-rubocop.

I dug a bit deeper here and found that it is broken because of a rubocop update related to this issue rubocop/rubocop#4666. It breaks on rubocop 0.56.0

from linter-rubocop.

Same thing happening here.

This provides a remediation but does not fix the underlying issue:
#48 (comment)

from linter-rubocop.