Code Monkey home page Code Monkey logo

Comments (8)

greenkeeper avatar greenkeeper commented on August 10, 2024

After pinning to 3.13.0 your tests are passing again. Downgrade this dependency 📌.

from linter-coffeelint.

Arcanemagus avatar Arcanemagus commented on August 10, 2024

I don't know what is breaking Atom in the CircleCI VM's, but it's getting annoying.

from linter-coffeelint.

AsaAyers avatar AsaAyers commented on August 10, 2024

This project hasn't had a change to its code in months. It runs the local coffeelint for your project, so users can upgrade/downgrade to whatever they want and falls back to the built in if no local coffeelint was found. I don't anticipate needing to many any changes unless the existing linter API gets removed.

How about we just depend on an exact version of eslint and stop getting these greenkeeper PRs.

from linter-coffeelint.

Arcanemagus avatar Arcanemagus commented on August 10, 2024

Unless you are willing to commit to checking every update of every dependency yourself and releasing updates when required I would much rather Greenkeeper stay enabled so that I can get notifications when something potentially needs attention. The occasional false positives like this are far less of a problem than not knowing something needed attention because nobody was checking it.

Just a note, the CircleCI issue isn't limited to this project, I've been seeing it across many of the linter providers, and it seems to be on Atom's side as the output shows it hasn't even hit the tests yet.

from linter-coffeelint.

AsaAyers avatar AsaAyers commented on August 10, 2024

I'm not talking about turning off GreenKeeper. Just removing the ^ from our devDependencies, because there's no reason to accept automatic upgrades of them. All they are doing is producing false positives.

"devDependencies": {
-    "eslint": "^3.9.1",
-    "eslint-config-airbnb-base": "^10.0.1",
-    "eslint-plugin-import": "^2.1.0"
+    "eslint": "3.9.1",
+    "eslint-config-airbnb-base": "10.0.1",
+    "eslint-plugin-import": "2.1.0"
  },

If one day you sit down to work on this and discover that you want to use a new rule or new feature of one of those, just go update the dependency then.

from linter-coffeelint.

Arcanemagus avatar Arcanemagus commented on August 10, 2024

That's not how Greenkeeper works at all... 😕

If you made that change, then you would be getting a PR for every single update of a dependency, since every single one would be a new version outside your allowed range.

The entire point of Greenkeeper is that you can leave the ranges in place, but get the benefit of pinning things since it will run your checks for every new version automatically, and only tell you when it finds a potential issue, like this issue itself is.

In this particular case it's a problem with the CI environment producing a false positive, but normally Greenkeeper only files an issue/PR when there is something that needs attention such as a new version outside the allowed range or an update that caused CI to fail.

from linter-coffeelint.

AsaAyers avatar AsaAyers commented on August 10, 2024

Thanks. I've never used Greenkeeper, so I misunderstood how it works.

Since CoffeeLint isn't being maintained I don't see any reason this repo would need maintenance. I'm changing my notification to Not Watching, so ping me if you ever need anything.

from linter-coffeelint.

Arcanemagus avatar Arcanemagus commented on August 10, 2024

Will do!

There are a few other providers in the same state (such as linter-jscs) that are really only being minimally kept up for people still forced to use that linter.

from linter-coffeelint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.