Breaking after update to React 18 about tippyjs-react HOT 10 CLOSED

Still it would be good to keep support as not everyone has a luxury to migrate everything all the time. I'll reserve some time today.

from tippyjs-react.

😭 I don't have the energy to fix this haha

In all honesty I kind of want to deprecate this package as it encourages bad patterns. I really recommend the new https://floating-ui.com/docs/react-dom-interactions package instead of this one!

That said, if you create a new CodeSandbox using React 18 with a simple usage of Tippy, there are no hooks errors. I suppose it might be something else in your app causing it, but I have no clue what :s

from tippyjs-react.

Totally understandable :) Thanks for maintaining it anyway :) I'll take a look a the library you mentioned :)

from tippyjs-react.

But just like @atomiks said before, it might be not related to React 18 per se. I'll dig deeper in our app 👌

from tippyjs-react.

@KubaJastrz fully agree. I'm going to put a notice on the README for newcomers but won't deprecate for now.

from tippyjs-react.

@KubaJastrz @atomiks looks like it's not the package itself. There's something else going on. Sorry for the confusion

from tippyjs-react.

@atomiks kinda confused, are you saying that react-dom-interactions package replaces tippy completely?

If it can be used with tippyjs, would be nice if you can make a sandbox with a basic example of integration between the two. That would probably give you an out too, with deprecation. Thanks

from tippyjs-react.

It's meant to replace @tippyjs/react yes. The vanilla library is still its own thing but trying to wrap it in React was inherently problematic

The only thing it doesn't have that Tippy does have is "singletons", but the design behind them needs to be completely rethought because there are a bunch of issues with them. For now, it has FloatingDelayGroup which satisfies one of the use cases of singletons.

from tippyjs-react.

Also I had this issue too (not with Tippy, but with the "invalid hooks" error) and it seemed like I still had a copy of React 17 being bundled in on my Parcel playground (in the Floating UI monorepo). I tried to upgrade only one package playground to React 18 but had to upgrade the whole monorepo all at once for it to work

from tippyjs-react.

@atomiks do you know of any resource for understanding what changes would need to be made to transition to Floating-UI? Or is it so different that all the code that relies on Tippy will just need to be rewritten?

Thank you for your fantastic work over many years!

from tippyjs-react.