Heredoc containing a closing PHP tag breaks syntax highlighting about language-php HOT 17 CLOSED

@Ingramz So should i'm push commit to fix this one? Cos there is no seems any activity on repository fix in mate

from language-php.

@Ingramz Okay then once @50Wliu merge things, i'm clean file, and then update this one

from language-php.

@zr9 did you sent a PR? having the same issue here.
Thanks

from language-php.

Confirm on that, it's a bit annoying

from language-php.

This is also happening when there is comment block syntax (/* and */) inside heredocs.

The file in my screenshot is part of the Symfony SensioDistributionBundle, available here.

from language-php.

yep. I see it too.

from language-php.

Likewise for single quotes (') or double quotes (") within a heredoc

from language-php.

There is 2 problems in atom/core probably.
Because grammar ignore "repository" and "injection" rules.

Good news so i'm can fix it by rewriting without that rules, here is simple trial example

But i'm need someone to help me write bug about grammar(En is not my native, so i'm sometimes unclear as hell).

And as well i'm need someone who can explain tricky parts in itself heredoc syntax,
like scope "string.unquoted.heredoc.php" now contain in rule double quote
and scope "string.unquoted.heredoc.nowdoc.php" now contain single quote
so i'm need to know diff and probably some examples of different languages(Js,SQL,Json,Regex,CSS) heredoc to test

from language-php.

@zr9 we've already concluded that it would be worthwhile fixing the root cause of this problem in first-mate package (see related discussion), so that all other bugs would fix on their own. The current solution is rather elegant (although, not working).

But it's still nice seeing someone giving their go at it.

from language-php.

@Ingramz Oh i'm not read references, so core bug already submitted. Then np :) But current solution is seems like working, so it can be fine as temporally fix until atom fixed "repository"

from language-php.

@zr9 sure, that's something people have suggested before.

You can compare your solution to the one in the pull request I submitted above. The changes got undone with later commits, but if you keep track of the commits throughout the pull request, you can sort-of see what was done there.

from language-php.

@Ingramz Yup almost similar, difference in "interpolation" since injection rule is not work, so interpolation need to get moved inside "heredoc_interior" after that it get fully working in current state, because at first heredoc get covered by main rules, then interpolated by php rules inside. Look on screen i'm posted above, or i'm can attach code if you wish so. So technically in current state full fix possible, and it even will be not dirty, only dirty thing is "interpolation" repeat. And more when repository will be fixed in core, it continue to work, so not get broken.

from language-php.

@Ingramz Tested, looks totally fine, here is screenshots.

Except of color issues, but that is atom/core other bug(or not bug).
Scopes for brief look fine too.

from language-php.

@zr9 sure, you can do it.

from language-php.

@diego-vieira Not yet, have a lot less time now, so slowdown a much, but still have plans to sent PR, or you can do so if you wish to.

from language-php.

I can confirm problem still occur.

from language-php.

Fixed by #184.

from language-php.