Code Monkey home page Code Monkey logo

Comments (2)

damieng avatar damieng commented on June 30, 2024 1

Thanks @tomchkk - While testing your change I also noticed another place. Comments can technically appear anywhere and that really messes up the grammar system as it's based on pattern matching using regexes rather than a traditional parser structure so we might not be able to support them everywhere - thankfully in these two cases it works just fine :)

from language-csharp.

tomchkk avatar tomchkk commented on June 30, 2024

I fixed this issue in my own implementation of the grammar by adding an include #comments in the type-declaration pattern:

Before:

      {
        begin: ":"
        end: "(?={|where)"
        patterns: [
          {
            include: "#type"
          }
          {
            match: "([\\w<>]+)\\s*"
            captures:
              "1":
                name: "storage.type.cs"
          }
        ]
      }

After:

      {
        begin: ":"
        end: "(?={|where)"
        patterns: [
          {
            include: "#type"
          }
          {
            match: "([\\w<>]+)\\s*"
            captures:
              "1":
                name: "storage.type.cs"
          }
          {
            include: "#comments"
          }
        ]
      }

I haven't got time to do my own pull request right now. Will do when I get a chance, if no one picks it up before.

from language-csharp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.