Code Monkey home page Code Monkey logo

Comments (3)

damieng avatar damieng commented on June 3, 2024

All of our IDE UI is based on scopes rather than filenames.

The two options would be:

  1. Handle it cleanly in the language server and just return null (preferred)
  2. Intercept things by overriding autolanguageclient behavior
  3. Possibly adding file-specific grammar for manifest.yml

Is there any reason the language server can't just return null for things it doesn't understand? (Item 1)

It would potentially be possible for us to provide an additional file matching filter in autolanguageclient that every single provider gets routed through but that does make things a bit messier everywhere.

from atom-languageclient.

BoykoAlex avatar BoykoAlex commented on June 3, 2024

The server returns empty contents. Think shouldn't be a problem to return null either. My concern was that the server receives the message it shouldn't. This is not a blocking issue for my server at all. Just a minor thing I've noticed.

from atom-languageclient.

damieng avatar damieng commented on June 3, 2024

Let's go with that for now - if it starts being a perf/maintenance problem we'll put an extra method in that package authors can override with path specific filtering.

from atom-languageclient.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.