Race condition with document changes and autocomplete requests about atom-languageclient HOT 4 CLOSED

I was going to speak to @maxbrunsfeld about this - it would be great if we could flush the changes out when we make an autocomplete request.

from atom-languageclient.

Can we just use onDidChangeText instead of onDidStopChanging? I think it behaves the exact same way, except that it fires once per transaction instead of every 300ms.

EDIT - We need to stop using onDidChange anywhere, because certain commands can cause that event to fire many times per keystroke (e.g. performing a search-and-replace, typing with many cursors, indenting many lines, etc).

from atom-languageclient.

We can retrieve the changes since the last onDidStopChanging event by calling buffer.createCheckpoint() in the event handler and then calling getChangesSinceCheckpoint when making an autocomplete request, but that will introduce some complexity because the next time the onDidStopChangingEvent fires, we will have already synced some of those changes.

from atom-languageclient.

@maxbrunsfeld Yep we will switch from onDidChange as soon as 1.17 becomes stable :) We need the oldText field, which was only added recently (see atom/text-buffer#223)

from atom-languageclient.