workspace/symbol & textDocument/documentSymbol about atom-languageclient HOT 7 CLOSED

atom-ide-ui 0.1.6+ has a searchable outline view now :) Still doesn't address project symbols, but it should help bridge the gap between symbols-view/outline-view.

from atom-languageclient.

I think the outline view is actually well suited to the data returned from LSP! The textDocument/documentSymbols verb gives us back a list of symbols with their parent names. If we assume that a container symbol comes lexically before the symbols inside it (as they do in all LSP languages, including even C/C++) then we can reconstruct the OutlineView correctly. The SymbolInfo.kind field gives a good icon to display in OutlineView too.

from atom-languageclient.

see @ljw1004's implementation for our internal LSP adapter:

facebookarchive/nuclide@dc59da7 (tree structure)
facebookarchive/nuclide@d734d34 (icons)

from atom-languageclient.

With the icon support it might be useful although I still think we're going to need go-to-symbol support for both the project and the current document. The latter might be do-able with further changes to outline view? Any thoughts on the former?

from atom-languageclient.

For the project-wide symbol search, Nuclide uses a "symbols" tab in the quick-open dialog. I've hooked it up so that LSP calls to workspace/symbol can populate it.

Oh gosh I really love the quick-open dialog. I've found it so incredibly useful, much friendlier than the symbol-search functionality in VSCode and VisualStudio. I love how it conveniently aggregates all the relevant search mechanisms in an easily-discoverable way, so it educates me about other search mechanisms I wasn't aware of, and it removes the up-front brain tax of having to decide which search mechanism to use (e.g. document-search vs project-search in VSCode).

from atom-languageclient.

documentSymbols now wired up to the revised Outline view using enhanced logic + syntax coloring + icons. Will create a separate issue for project symbols.

from atom-languageclient.

Where's the issue for project symbols? I might dig into exposing that data.

from atom-languageclient.