-IncludeTotalCount not working about confluenceps HOT 3 OPEN

This parameter is auto-generated with

[CmdletBinding(SupportsPaging = $true)]

The TotalCount is defined in this line:

$PSCmdlet.PagingParameters.NewTotalCount($response.size, $Accuracy)

source

$accuracy is a float between 1 and 0.
1 means the number is 100% accurate
0 means the number is 0% accurate
As we don't get any indication of the REST how many results will be returned, 0 was the most appropriated at the time.

However

We can count the results per page and send it along with the self-invocation in order to know how many results were returned.
And only display the Total count at the end of the result set.

Would that be ok for you?

from confluenceps.

...I did not realize SupportsPaging auto-generated parameters.

I like that suggestion. As a user, I don't expect count to come before the results anyway.

from confluenceps.

How to implement this

• Add a [int]$count = 0 parameter to Invoke-Method
• self-invoke passing the count of $count + $result.count
  https://github.com/AtlassianPS/ConfluencePS/blob/develop/ConfluencePS/Private/Invoke-Method.ps1#L195
• move the display of the total ($PSCmdlet.PagingParameters.NewTotalCount($count, $Accuracy)) to the end
  https://github.com/AtlassianPS/ConfluencePS/blob/develop/ConfluencePS/Private/Invoke-Method.ps1#L196

} elseif ($count -gt 0) {

from confluenceps.