Comments (2)
Sharing commit messages over would be ideal 👌
Why we are not doing that right now:
- we are technically not synchronising individual commits, rather, we are crushing all changes in a given time period for the pdnd related code into a single commit
- The Pragmatic drag and drop code lives in a monorepo which contains private packages. We opted for an approach (for now) that would not leak any (potentially) private information. Commit messages could contain sensitive information that is not intended for public visibility.
- A commit in the mono repo could span a number of packages (ie some public packages, and some private packages)
Is this problem solvable? Yes. But I wanted to give some context.
For now, you can see all the change information in our changelogs (flourish example)
Open to suggestions on how we could improve things, especially fairly low hanging options.
Perhaps one possibility for now is replicating our changelog information in Github releases, as Github releases allow you to see the code diff between versions
from pragmatic-drag-and-drop.
I agree, the Git commit history matters to outsiders when assessing the project's qualities.
The Atlassian merges indeed look out of place.
Would it be possible to use "conventional commits" syntax for commit messages, as well as atomic "stash" for merge strategy in order to avoid scattered commit units in the chronological history?
from pragmatic-drag-and-drop.
Related Issues (20)
- Vertical trees HOT 3
- Inconsistent drag preview opacity HOT 3
- Drag issue when dragging *new* item onto a tree. HOT 7
- Adapter: Element adapter link in documentation broken. HOT 3
- Absence of handling events in capture phase: Design decision or just current scope? HOT 1
- TypeScript: Cannot find module '@atlaskit/pragmatic-drag-and-drop/adapter/element-adapter' HOT 2
- In desktop Safari drag preview can include elements behind container. HOT 7
- canDrop = false not working on tree root element HOT 5
- Making a next.js Link element draggable. HOT 1
- support drag and drop inside iframe HOT 1
- Feature: Make tree hitbox zones configurable
- Making an element draggable prevents user from highlighting and copying text content inside the element HOT 4
- Can't detect drag from external inside `textarea` HOT 6
- Drag and drop does not work in Chrome dev tools device mode HOT 1
- dynamic-table - Is there any plan to support to react 18?
- Mouse Pointer Stuck to Top Left in Drag Preview Despite Using `preserveOffsetOnSource` Utility HOT 3
- { source } is not ready on canDrop, onDrag in dropTargetForExternal
- Changelog / Release notes? HOT 2
- How to determine the distance from the edge of the container in a drop event?
- Bug: Safari Autoscroll Offset HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pragmatic-drag-and-drop.