Menu in the Demo app does not reflect my current location about ui HOT 4 CLOSED

Hi,

This thread is now old and inactive.

If we want to have this implemented then it can be submitted as a feature request (not for the demo, but as a capability in general) or added in the wishlist in order to be examined later. Perhaps it could part of the Page object in v2 if it gets implemented.

Right now as this issue stands it's more of a bug/discussion rather than a feature request so I suggest closing it or revamping it to be a feature request if it is to be implemented.

Thanks!

from ui.

Need to add active class to active menu item.
Probably that can be done somewhere in menu renderView() https://github.com/atk4/ui/blob/develop/src/Menu.php#L98

Something like:

if ($_SERVER['REQUEST_URI'] == $this->app->url($action)) {
    $this->item->addClass('active');
}

or maybe it's better to do this in Menu->addItem() method somewhere here: https://github.com/atk4/ui/blob/develop/src/Menu.php#L32

from ui.

The active is not a problem, it's the automated detection of where you are on the page.

from ui.

Fixed by #1120

Closing this. Feel free to reopen if needed.

from ui.