Breakpoint 2.x: Remove "force all" setting about breakpoint HOT 5 CLOSED

The issue I have with that is it's technically not correct. The spec allows for the all media type to be freely omitted and for it still to work, and the reason we omit it and have the force all variable is if you would like to force the printing of the all media type. Our current setup allows for optimization out of the box optimization that will always work while providing an easy way to override that optimization while not introducing incorrect syntax to the user.

On Saturday, March 16, 2013 at 1:48 PM, Rob Wierzbowski wrote:

Removing the "all" media type by default, and then adding it back in with a settings variable is complex. Why not have "false" as an allowable default media type, which prints nothing, and let default media type "all" to print as you would expect?
Thoughts?

—
Reply to this email directly or view it on GitHub (https://github.com/canarymason/breakpoint/issues/39).

from breakpoint.

If "false", or omitted and inferred 'all' media, is the default, Breakpoint would still have the same out of the box optimization that would always work. I see the idea of providing correct syntax to the user, but in last month's Sassy Pgh meetup I went over breakpoint quite a bit with some curious users and they found the "force all" confusing. Typing "all" as the default media query can be seen as de facto the user asking to "force all", and removes the need for an extra settings variable.

from breakpoint.

I would prefer better documentation as to its purpose rather than introducing a false media type.

On Mar 16, 2013, at 2:06 PM, Rob Wierzbowski [email protected] wrote:

If "false", or omitted and inferred 'all' media, is the default Breakpoint would still have the same out of the box optimization that would always work. I see the idea of providing correct syntax to the user, but in last month's Sassy Pgh meetup I went over breakpoint quite a bit with some curious users and they found the "force all" confusing. Typing "all" as the default media query can be seen as de facto the user asking to "force all", and removes the need for an extra settings variable.

—
Reply to this email directly or view it on GitHub.

from breakpoint.

I'm not recommending a false media type, I'm recommending

$breakpoint-default-media: false; 

Aka, no automatically added media type. Two very different things. I think it comes down to respecting user input -- css developers have reasons for @media all (rules), and they self optimize and write @media (rules). Breakpoint can be simplified by acknowledging that css authors mean what they type. The confusion among users at the meetup was not "what does force all do?", but "why not just output what users input?".

Revising this behavior would also allow the possibility of some media queries containing all media types while others don't, which is impossible in the current setup without setting and unsetting settings variables around a breakpoint include.

from breakpoint.

After having discussed with Mason, we've decided to close this issue and keep it as is

from breakpoint.