Support for r2dbc-spi's Optional Interface 'LifeCycle' about r2dbc-mysql HOT 6 CLOSED

You're absolutely right. There is no need to implement the Wrapped interface for MySqlConnection and MySqlConnectionFactory, as they are not wrappers. If, however, we come across a class that wraps an r2dbc-spi implementation, it would be advisable to implement Wrapped in that case.

from r2dbc-mysql.

Hi @jchrys,

Do these interfaces need to be implemented anywhere or do they just need to be created? I think MySqlConnection has to implement Lifecycle. I don't think Wrapped needs to be implemented anywhere, it's up to the end user. Closeable might have to be implemented by MySqlConnectionFactory etc.

from r2dbc-mysql.

The MySqlConnection should to do nothing in postAllocate, only contains one job in preRelease, which is to rollback if it is in a transaction.

Which means postAllocate will return an empty Mono, and preRelease will be an alias as rollbackTransaction.

from r2dbc-mysql.

Hmmm, I noticed that the COM_RESET_CONNECTION command, which should be more suitable as preRelease, it resets almost all state, including temporary tables, transactions, etc.

from r2dbc-mysql.

Forget it, it turns out that COM_RESET_CONNECTION is not a good solution.

This command not being supported in 5.6.x and below, it will also cause all prepared statements to be cleared.

from r2dbc-mysql.

#171 #175

from r2dbc-mysql.