Code Monkey home page Code Monkey logo

Comments (28)

github-actions avatar github-actions commented on July 19, 2024

Welcome to AsyncAPI. Thanks a lot for reporting your first issue.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

from spec-json-schemas.

jonaslagoni avatar jonaslagoni commented on July 19, 2024

Good catch @c-pius, can see the parser does not have the property as well. Tagging @fmvilas to get his perspective, think this is something that was added early on.

from spec-json-schemas.

jonaslagoni avatar jonaslagoni commented on July 19, 2024

I can see that messageTrait andchannelItem also contains a deprecated property which are not present in the tools.
https://github.com/asyncapi/asyncapi/blob/5ad3a971c82b33717fdec4c8d78173294ae253ff/versions/2.0.0/schema.json#L909
https://github.com/asyncapi/asyncapi/blob/5ad3a971c82b33717fdec4c8d78173294ae253ff/versions/2.0.0/schema.json#L501

from spec-json-schemas.

jonaslagoni avatar jonaslagoni commented on July 19, 2024

Related issue about introducing deprecation/sunset property for the channel - asyncapi/spec#305

from spec-json-schemas.

derberg avatar derberg commented on July 19, 2024

I don't think the deprecated flag is supported on a Message or a Channel level. At least I know about Channel -> asyncapi/html-template#81 (comment) but don't remember where from 😅

It might be just a bug in the schema. Remember that schema != spec md file

But yeah, @fmvilas should confirm

from spec-json-schemas.

fmvilas avatar fmvilas commented on July 19, 2024

Yeah, I think that's a bug. Always follow the Markdown version of the spec. However, if you think that it still makes sense to have a deprecated property at MessageObject level, then let's open an issue to propose it.

from spec-json-schemas.

c-pius avatar c-pius commented on July 19, 2024

Alright, thanks for the info. I also just encountered the deprecated property by chance. As of now our use case doesn't require a deprecated property on message level. But I could imagine this in the future (maybe even with some more information like successor message, sunset date, etc). If so, I would think about an own extension or proposing something for the MessageObject.

For now you can close this issue from my side.

from spec-json-schemas.

fmvilas avatar fmvilas commented on July 19, 2024

Yes, there's a feature request for this (although at channel level): asyncapi/spec#305. Leaving this open because it needs to be fixed. Thanks!

from spec-json-schemas.

github-actions avatar github-actions commented on July 19, 2024

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

from spec-json-schemas.

github-actions avatar github-actions commented on July 19, 2024

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

from spec-json-schemas.

github-actions avatar github-actions commented on July 19, 2024

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

from spec-json-schemas.

derberg avatar derberg commented on July 19, 2024

/help

from spec-json-schemas.

asyncapi-bot avatar asyncapi-bot commented on July 19, 2024

Hello, @derberg! 👋🏼

I'm Genie from the magic lamp. Looks like somebody needs a hand! 🆘

At the moment the following comments are supported in issues:

  • /good-first-issue {js | ts | java | go | docs | design | ci-cd} or /gfi {js | ts | java | go | docs | design | ci-cd} - label an issue as a good first issue.
    example: /gfi js or /good-first-issue ci-cd

from spec-json-schemas.

asyncapi-bot avatar asyncapi-bot commented on July 19, 2024

Hey @asyncapi-bot, something is wrong with your command please use /help for help.

from spec-json-schemas.

asyncapi-bot avatar asyncapi-bot commented on July 19, 2024

Hello, @asyncapi-bot! 👋🏼

I'm Genie from the magic lamp. Looks like somebody needs a hand! 🆘

At the moment the following comments are supported in issues:

  • /good-first-issue {js | ts | java | go | docs | design | ci-cd} or /gfi {js | ts | java | go | docs | design | ci-cd} - label an issue as a good first issue.
    example: /gfi js or /good-first-issue ci-cd

from spec-json-schemas.

asyncapi-bot avatar asyncapi-bot commented on July 19, 2024

Hey @asyncapi-bot, something is wrong with your command please use /help for help.

from spec-json-schemas.

asyncapi-bot avatar asyncapi-bot commented on July 19, 2024

Hello, @asyncapi-bot! 👋🏼

I'm Genie from the magic lamp. Looks like somebody needs a hand! 🆘

At the moment the following comments are supported in issues:

  • /good-first-issue {js | ts | java | go | docs | design | ci-cd} or /gfi {js | ts | java | go | docs | design | ci-cd} - label an issue as a good first issue.
    example: /gfi js or /good-first-issue ci-cd

from spec-json-schemas.

asyncapi-bot avatar asyncapi-bot commented on July 19, 2024

Hey @asyncapi-bot, something is wrong with your command please use /help for help.

from spec-json-schemas.

asyncapi-bot avatar asyncapi-bot commented on July 19, 2024

Hello, @asyncapi-bot! 👋🏼

I'm Genie from the magic lamp. Looks like somebody needs a hand! 🆘

At the moment the following comments are supported in issues:

  • /good-first-issue {js | ts | java | go | docs | design | ci-cd} or /gfi {js | ts | java | go | docs | design | ci-cd} - label an issue as a good first issue.
    example: /gfi js or /good-first-issue ci-cd

from spec-json-schemas.

asyncapi-bot avatar asyncapi-bot commented on July 19, 2024

Hey @asyncapi-bot, something is wrong with your command please use /help for help.

from spec-json-schemas.

asyncapi-bot avatar asyncapi-bot commented on July 19, 2024

Hello, @asyncapi-bot! 👋🏼

I'm Genie from the magic lamp. Looks like somebody needs a hand! 🆘

At the moment the following comments are supported in issues:

  • /good-first-issue {js | ts | java | go | docs | design | ci-cd} or /gfi {js | ts | java | go | docs | design | ci-cd} - label an issue as a good first issue.
    example: /gfi js or /good-first-issue ci-cd

from spec-json-schemas.

derberg avatar derberg commented on July 19, 2024

@KhudaDad414 have a look, I luckily made it stop 😆

from spec-json-schemas.

derberg avatar derberg commented on July 19, 2024

Also, when fixing can you also improve below message. My bot complains it is not much positive, probably because of wrong

Screenshot 2022-01-13 at 17 19 29

from spec-json-schemas.

derberg avatar derberg commented on July 19, 2024

/help

from spec-json-schemas.

asyncapi-bot avatar asyncapi-bot commented on July 19, 2024

Hello, @derberg! 👋🏼

I'm Genie from the magic lamp. Looks like somebody needs a hand! 🆘

At the moment the following comments are supported in issues:

  • /good-first-issue {js | ts | java | go | docs | design | ci-cd} or /gfi {js | ts | java | go | docs | design | ci-cd} - label an issue as a good first issue.
    example: /gfi js or /good-first-issue ci-cd

from spec-json-schemas.

derberg avatar derberg commented on July 19, 2024

/gfi docs

from spec-json-schemas.

github-actions avatar github-actions commented on July 19, 2024

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

from spec-json-schemas.

github-actions avatar github-actions commented on July 19, 2024

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

from spec-json-schemas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.