Code Monkey home page Code Monkey logo

Comments (8)

peter-rr avatar peter-rr commented on August 26, 2024 4

Hi all! 👋 @magicmatatjahu @Souvikns @derberg
I've been having a look and investigating a bit on this issue and I'd like to start working on it as a starting point to contribute to the CLI repo. If no objections from your side, please let me work on it and I'll get back to you with a proposal as soon as I have some working code 💪 Cheers!

from cli.

Souvikns avatar Souvikns commented on August 26, 2024 1

Maybe we have a --output flag that takes a path as an input. Converts the old version to the new version and outputs in that path, and if the --output flag is missing we can just update the original file.

from cli.

derberg avatar derberg commented on August 26, 2024 1

Our comverter-js has builded custom CLI, but we should move it to the main CLI.

definitely, same with generator. This is the ultimate goal of this CLI. One CLI to rule them all 😄

I would definitely like CLI to be friendly and interactive, and when you do asyncapi convert, you get an interactive response from the CLI with list of versions that you can convert too, so you select the version that you want manually. And of course you can skip this interactiveness with a flag like --targetVersion or -t.

the future of the command
my opinion is that we should not put = between asyncapi convert and the JavaScript Converter that we have. Meaning: that now asyncapi convert will invoke the list of available target versions, but simply because in code we will by default support AsyncAPI now, but in future this should be definitely extendable, so we can add other formats, why not 🤷🏼

--output
imho we should do --output as it will be universal for other commands, not >. And if you do not provide --output or -o then we print the result in the terminal

from cli.

derberg avatar derberg commented on August 26, 2024 1

@peter-rr go ahead mate!

from cli.

github-actions avatar github-actions commented on August 26, 2024

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

from cli.

magicmatatjahu avatar magicmatatjahu commented on August 26, 2024

Solution that we should consider for that issue asyncapi/community#249 It's only an idea so please treat it as suggestion, not final approach. Feel free to comment :)

from cli.

fmvilas avatar fmvilas commented on August 26, 2024

I think this issue can be closed as it was implemented by @peter-rr in #188. @Souvikns @magicmatatjahu can you close it? I can do it but I should not 😄

from cli.

magicmatatjahu avatar magicmatatjahu commented on August 26, 2024

Yeah, it's implemented. Thanks!

from cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.