Invalid image name when the image tag is integer about airflow-chart HOT 6 CLOSED

I'm not sure where we'd place anything in docs where folks would find it when they hit it. I also think the schema check provides a decent error message now. I'm not sure we should do anything for this. Maybe now search engines will find this issue if folks look that way 🤷.

from airflow-chart.

Interesting edge case! I was able to reproduce this almost 3 years later:

$ helm template . --set airflow.images.airflow.tag=5060547 | grep ap-airflow
Error: values don't meet the specifications of the schema(s) in the following chart(s):
airflow:
- images.airflow.tag: Invalid type. Expected: [string,null], given: integer

Thanks for the report @dwiajik and I am sorry for getting back to you so late! I just realized I was not watching all activity on this repository 🤦‍♂️

I've opened an internal ticket to track this https://github.com/astronomer/issues/issues/6148

from airflow-chart.

This is actually a problem with the OSS airflow chart. I have expanded airflow-chart 1.11.1 and run:

$ helm template . --set images.airflow.tag=5060547
Error: values don't meet the specifications of the schema(s) in the following chart(s):
airflow:
- images.airflow.tag: Invalid type. Expected: [string,null], given: integer

I also made a branch with tests showing the problem. https://github.com/astronomer/airflow-chart/tree/6148-integer-docker-tags

CC @jedcunningham

from airflow-chart.

I found the fix for the shell. --set-string images.airflow.tag=5060547 It seems like we should be using this in all cases, so we can fix that on our end. I can't imagine a place where we'd want input value to be interpreted as an integer. This is definitely a limitation of the shell's dynamic typing and helm's implementation that attempts to add types. It seems unintuitive to me.

from airflow-chart.

I think there's probably not a bug here. With yaml, the values should be specified as strings, because that's what they are, so something like:

airflow:
  images:
    airflow:
      tag: "5060547"

And on the CLI users should be using --set-string, because the data they are giving is a string, not an integer.

Other than that, the only thing I can think of to do is educate people on how helm handles types.

from airflow-chart.

@jedcunningham I agree. I think we can close this. @dwiajik if you want to respond about this in the thread feel free, though since I took so long to respond I would not be surprised if it's not relevant anymore. I'm going to go ahead and close this one for now.

from airflow-chart.