Handling of COMMENT, HISTORY, END cards differs wrt cfitsio about fitsio HOT 3 OPEN

this begs the question as whether we shouldn't just return the []Card, or have a method to retrieve the n-th card (otherwise, we'd always get the first occurence of COMMENT or HISTORY via the Header.Get(name string) method...
or rename the currrent Get(string) into GetByName(string) and introduce Get(int).
but Header.Cards() []Card SGTM (carefully documenting one shouldn't mess with modifying their content.)

from fitsio.

For my use case, which basically consists of scanning all the cards in all header units of a given file and perform some actions depending on the value of some of them, Header.Cards() []Card would be perfect and much more efficient indeed that to repeatedly call Header.Get(key). A note in the documentation could remind the users that they should consider the returned Card slice data as read-only.

In that case, Header.Cards() []Card should return all the cards (including SIMPLE, COMMENT, HISTORY, END) and preserve their order as found in the file.

I would suggest to keep Header.Get(key) which is convenient and modify Header.Comments() []string (note the plural) to return several values, instead of just one value as they currently does. I don't know for sure if a well formed FITS file is supposed to have several HISTORY cards: if that's the case, Header.History() could also become Header.Comments() []string.

from fitsio.

apologies for the belated answer.

do you want to give this a go and send a PR?

from fitsio.