Comments (4)
@rafael-carrillo This is done right? Can we close? What branch is this on (approx-admm)? Can/should we merge to master? I suppose there are other updates on that branch that we might not be ready to merge. However, they should be independent and not interact with any existing code right?
@mdavezac We're going to need these updates for supporting weighted SDMM when running on CASA measurement sets. Would you recommend we merge? We can discuss further when we speak later today.
from sopt.
Yes, this is done. The changes are on the aprox-admm branch. I think we can merge this branch to the master branch since the admm algorithm development is independent of the SDMM code. One issue here: As I did things I created another function for sdmm to support weighting instead of modifying the texting function. The right way to go is to update the existing function but this will take longer since we will need to update all the examples in SOPT and in PURIFY. Which is something that we will have to do anyway at some point.
On 10 Jun 2015, at 11:56, Jason McEwen [email protected] wrote:
@rafael-carrillo https://github.com/rafael-carrillo This is done right? Can we close? What branch is this on (approx-admm)? Can/should we merge to master? I suppose there are other updates on that branch that we might not be ready to merge. However, they should be independent and not interact with any existing code right?
@mdavezac https://github.com/mdavezac We're going to need these updates for supporting weighted SDMM when running on CASA measurement sets. Would you recommend we merge? We can discuss further when we speak later today.
—
Reply to this email directly or view it on GitHub #10 (comment).
from sopt.
Thanks Rafa, that's what I thought. That's again for implementing this so quickly after our recent chat. Good point about the new SDMM function. Let me discuss with @mdavezac later today about the merge.
from sopt.
Just spoke to @mdavezac about this and he had the excellent suggestion that we should have a development branch. This is essentially a branch for the cutting edge version and will collect developments from separate branches. Updates to master should then just come from development when ready. We'll merge approx-admm to development now to pick up these updates.
from sopt.
Related Issues (20)
- Modernise the library by bringing the codebase up to C++17 standards
- Modernise: Use concatenated nested namespaces instead of hierarchical nested namespaces
- Modernise: Replace typedefs with using aliases
- Modernise build system: Incorporate simple enhancements to top-level CMakeLists.txt
- Modernise: replaces C-style casts with static_cast< >
- Possible bugs (dangling references) due to returning reference to temporary object in l1_proximal.h?
- Code quality: Shadow variable declaration in l1_proximal.h HOT 2
- Code quality: Possibility to declare some outparams as reference to const in some header files?
- Performance: Possibility to use std::reduce or std::accumulate instead of raw loop
- Expensive deep copy operation due to std::string pass by value
- Performance: Possibility to use std::transform instead of raw loop in linear_transform.cc
- Handle unused variables in the project
- Safety/Perf: Aim for const correctness
- Code quality: Repeated branch in conditional chain HOT 2
- Identify and cleanup multiple consecutive namespace closing and reopening within same code/header file
- Clean some empty files not currently used in the project
- Code-quality: Multiple declarations in single line
- Build the project using another generator e.g. Ninja to verify that the project does not use Makefiles-specific constructs
- Apparent bug converting to real
- Tests running really long HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sopt.