Email link provider about astro-auth HOT 4 OPEN

Just following up on this. I'm also happy to just start on a pr if that works better?

from astro-auth.

@waspeer Thank you for your interest in contributing to the Astro Community. It's great seeing more people interested in taking the initiative and contributing. Sorry for the delay in getting back to you; @osadavc has been preoccupied, and so has the Astro team post-v1; I was just able to set some time aside to reply. As for your suggestion, it's most defiantly a good one. My main concern is how this affects the attack surface of the package. This concern is further amplified when you consider the current security state of the package. Beyond that, I don't see any problem integrating your idea into the integration.

I suggest we wait for a week (or two?), if possible. I'm already working on several changes required to improve our current security posture that should be pushed by then. I think then we should revisit this conversation and see how we can work together to integrate your suggestion.

from astro-auth.

Hey @ran-dall,

All good! Just let me know when/how you want to proceed.

As I mentioned in the issue, I have a working example already (built on top of the CredentialsProvider). I expect most of that code can be used for this integration, if you don't see any security vulnerabilities in the approach I outlined above.

from astro-auth.

Friendly little follow-up ✨

from astro-auth.