Comments (4)
I've the feeling that adding a Language
attribute to Item would do the trick but I may be missing something 🤔 On reading the ttml, language attribute should of an item would be update accordingly and on writing, we could either repeat the xml language
attribute for each item (which would be simpler in the code), or add separate divs if we detect an item with a language 🤔
from go-astisub.
All the parsing will return the result as object Subtitles, and there is only one master language for the whole object, we can not know which Items belong to which language, that's why. If we want to fix it, we will break the Subtitles object structures and affect user of this library, they need to change their code to adapt with new structure. There is a way to achieve fixing the issue by storing language for each Subtitles Items, yeah, just like what you said, but it sounds inefficiency. But seems like that it is the only way for this current structure. And then, a question pop up. When converting the multiple languages TTML to WebVTT (or other formats), should we output multiple WebVTT files? I think it is yes, we should append the language into the name of WebVTT file for distinguishing them.
from go-astisub.
If we want to fix it, we will break the Subtitles object structures and affect user of this library, they need to change their code to adapt with new structure
Which changes are you thinking about? 🤔
from go-astisub.
Nothing special, just do not store Items
directly in Subtitles
, we can have some kind of Wrapper that store metadata (contains languages) and Items
, then Subtitles
can include that Wrapper. Another way is returning a list of Subtitles objects which different languages when parsing from the input, instead of just returning only one object like what we are doing currently. Those are my thoughts.
from go-astisub.
Related Issues (20)
- clean up go.sum
- func formatDuration has a bug will to output wrong result HOT 4
- Access for adding new features to base HOT 1
- iTunes Timed Text reader and writer
- not support .ass file? HOT 4
- Populate originalEpisodeTitle and originalProgramTitle for STL file convertion HOT 4
- Can go-astisub parse HDMV/PGS subtitle? HOT 1
- convert ass subtitle contains more than one language to vtt fail HOT 6
- Can't change fontColor for STL file HOT 2
- TTML text parsing issues with new lines HOT 2
- What to expect to be supported by ttml parser? HOT 5
- Support AddItem(s) and RemoveItem(s) HOT 2
- Handle dot as well for SRT files HOT 1
- Subtitles.go String() - why are subtitle lines joined with a " - ", instead of a new line ("\n")? HOT 3
- Escape problem when convert from other formats to VTT, and from VTT to other formats HOT 11
- Example usage ReadFromSRT in the README is incorrect HOT 4
- Broken VTT styling in output (0.26.0 only) HOT 3
- The indexes always are zero (v0.26.1 only) HOT 2
- Timestamp tag regression in 0.26.0 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-astisub.