"Upload & replace all slots" -> slots are renamed unintentionally about addon-bluetooth-webgui HOT 5 CLOSED

a sideeffect of this renaming procedure is that the maximum slotname size could be exceeded, which results in a different slotname in webGUI and device so the this slot cannot be selected anymore.

I would suggest to have the "replace all slots" functionality as default. IMO, adding single slots is a special case which should be hidden by default (maybe a button "add/select individual slots" which then displays the slotnames + checkboxes).

In case of existing slot name, I'd suggest to delete the existing slot, thereby getting rid of the rename problem.

from addon-bluetooth-webgui.

a sideeffect of this renaming procedure is that the maximum slotname size could be exceeded, which results in a different slotname in webGUI and device so the this slot cannot be selected anymore.

I had that case, the last ")" was missing on the device.

I would suggest to have the "replace all slots" functionality as default. IMO, adding single slots is a special case which should be hidden by default (maybe a button "add/select individual slots" which then displays the slotnames + checkboxes).

I find this functionality very useful, but it could be possible to "hide" it behind an advanced button (or something similar).

In case of existing slot name, I'd suggest to delete the existing slot, thereby getting rid of the rename problem.

Maybe we could ask "overwrite" or "rename"? Like in the file managers...

from addon-bluetooth-webgui.

Thanks for reporting! Renaming slots on "upload an replace all" is indeed a bug and also the issue with bypassing the maximum slot length by renaming has to be fixed.

I would do the following:
By default only show "upload and replace all slots" and additionally a link to show advanced options where single slots can be selected. Would look like this: https://i.imgur.com/QkdoJIx.png
In the advanced options there could also be a checkbox "overwrite existing" to define if existing names should be overwritten or renamed.
What do you think?

from addon-bluetooth-webgui.

looks great !

from addon-bluetooth-webgui.

cool: if you add fixes <link-to-issue> in a git commit comment, it automatically closes the issue on github :)

from addon-bluetooth-webgui.