Code Monkey home page Code Monkey logo

Comments (3)

kevinchalet avatar kevinchalet commented on June 1, 2024 1

I'm minded to not change anything for this, as this is customisable using built-in configuration functionality, even though it is maybe not 100% intuitive due to us building the URLs for you in the default case.

Sounds very reasonable. Customizing the endpoints is generally reserved to very specific scenarios, so not sure it's worth changing anything on our end.

from aspnet.security.oauth.providers.

martincostello avatar martincostello commented on June 1, 2024

We can look at making a change to have it only set the values if they are null.

In the meantime, you could workaround this with the following code snippet:

services.AddOkta("TestScheme");
services.AddOptions<OktaAuthenticationOptions>("TestScheme")
        .PostConfigure((options) =>
        {
            options.AuthorizationEndpoint = "whatever";
            options.TokenEndpoint = "whatever";
            options.UserInformationEndpoint = "whatever";
        });

EDIT: Updated code snippet after testing.

from aspnet.security.oauth.providers.

martincostello avatar martincostello commented on June 1, 2024

I'm minded to not change anything for this, as this is customisable using built-in configuration functionality, even though it is maybe not 100% intuitive due to us building the URLs for you in the default case.

You can see in this test that you can further configure the options after OktaPostConfigureOptions has run: martincostello@cdeb022#diff-410fc1906e363b918ed101da30985db9efb377bb50945d8e3c058af8a7e584ff

Otherwise if we use ??= instead of = to assign the endpoint property values, the original way of configuring things would work, or PostConfigure can be simplified to Configure in that case.

Thoughts @kevinchalet?

from aspnet.security.oauth.providers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.