Need modification in experience cards. about masterportfolio HOT 14 CLOSED

I can modify the cards of the site as per the pic given above, Assign me the task.

from masterportfolio.

@dineshnadimpalli, we need to change this thing that we need to make width 100% in this

from masterportfolio.

Thanks @ashutosh1919 😁. Sure, will try something with 100% width and will also try adding the description part to this one.

from masterportfolio.

Now this task is open to anyone.

Please comment here if you want to take it up and I will assign it to you!

from masterportfolio.

Sure @Vyomrana02, assigning it to you.
Reach out in case of any queries!

from masterportfolio.

Is this Okay??

from masterportfolio.

@Vyomrana02 Looks good.

How about adding skill icons as well and if skill icons are not there, then maybe that empty space shouldn't be there?

from masterportfolio.

Is this Okay!!
I have removed blank space cause in the given cards we have an key field named languages so here in portfolio.js we dont have this field.
The output after removing space is like this

from masterportfolio.

This also looks fine to me, what do you think @ashutosh1919, Should we add a description or skills to the cards?

Also @Vyomrana02, in the latest image I can see the vertical lines behind the blue circles, that shouldn't happen.

from masterportfolio.

@saiteja13427 @Vyomrana02 I think we should include description for the job role.

from masterportfolio.

Yeah, let us add description! @Vyomrana02 maybe you can add description and raise a PR

from masterportfolio.

@Vyomrana02 have you raised a PR or are you still working in your fork? Coz I don't see PR here. Please attach it here if you have already raised.

from masterportfolio.

@ashutosh1919 I have created PR and as per @saiteja13427 i have edited it.
Output:-

from masterportfolio.

Merged in #296 .

from masterportfolio.