Error: next3.4 could not get parsed about tmux.nvim HOT 13 CLOSED

Heho,

currently on small vacation with the family. I'll soon get home and look into the issue and the pr asap.

Kind regards
Alexander

from tmux.nvim.

@twidxuga
i made it a little bit more strict:

value = value:gsub("next%-", "")

all specs added for the next- release :D

from tmux.nvim.

Cool, ty for using my work! means much to me!
Closing the issue.

from tmux.nvim.

Just tested and confirmed it works.

Cheers, much appreciated!

from tmux.nvim.

This issue affects me as well. I am using tmux next-3.3.

from tmux.nvim.

One possible fix, that works for me (and possibly for everyone else) is to change lua/tmux/version/parse.lua to:

local log = require("tmux.log")

local function get_order(char)
    if char == nil or char == "" then
        return 0
    end
    return string.byte(char) - string.byte("a") + 1
end

local M = {}
function M.from(value)
    if value == nil then
        log.error("nil could not get parsed!")
        return {}
    end

    value = value:sub(value:find("%d"),value:find("$"))

    if value:match("^%d+%.%d+[a-z]?$") == nil then
        log.error(value .. " could not get parsed!")
        return {}
    end

    local index_dot = value:find("%.")
    local index_patch = value:find("[a-z]")

    local minor
    if index_patch == nil then
        minor = tonumber(value:sub(index_dot + 1))
    else
        minor = tonumber(value:sub(index_dot + 1, index_patch - 1))
    end

    local patch = 0
    if index_patch ~= nil then
        patch = get_order(value:sub(index_patch))
    end

    return {
        major = tonumber(value:sub(1, index_dot - 1)),
        minor = minor,
        patch = patch,
    }
end

return M

Note the additional value = value:sub(value:find("%d"),value:find("$")) at the beginning of function M.from()

from tmux.nvim.

Thank you Alexander, no hurry on my end. Please enjoy your vacation with your family!

from tmux.nvim.

Heho,

can you please try the fix?

Kind regards

from tmux.nvim.

Perfect, thank you!

from tmux.nvim.

Actually, I was just testing this. It doesn't work with:

value = value:gsub("next%-", "")

Because the '-' is not in the value argument to function M.from(value)

Suggest just removing the %- from the expression. So this should work:

value = value:gsub("next", "")

Thanks again!

from tmux.nvim.

ok, i hope we got it now :D

from tmux.nvim.

Nice, thanks for the support

from tmux.nvim.

It's working for me too, thank you! 🎉

from tmux.nvim.