[Proposal] Update Legacy File Plugin API about asdf HOT 5 CLOSED

Closing this issue since all the PRs have been merged and are now in the latest release. Thanks for all the great work @rockwood !

from asdf.

I added the legacy file support and I agree with everything here. The less work the plugins have to do the better. I might be able to create a pull request sometime this week.

Do you happen to know which plugins include get-version-from-legacy-file? I think I only added it to the Ruby plugin. If it's not widely used we might be able to get away with just dropping support for it.

@HashNuke @tuvistavie any thoughts on this? What do think about tagging a release before making these changes? Might save us some headaches in the future...

from asdf.

I believe these are the only plugins currently supporting the legacy file feature:

• https://github.com/asdf-vm/asdf-ruby
• https://github.com/tuvistavie/asdf-python

I agree that we should solidify a release process(#70) before making any changes.

from asdf.

Sorry for the late reply, and thanks for the great proposal!

Is it safe to assume that all plugins will want to start from the current directory and search the parent directory until it finds the needed file? I am not aware of any version manager which does not respect this behavior, but just to be sure.

I think @rockwood proposal is a great improvement over the current API, and I think we should move to it before other plugins start implementing the legacy file feature.
If the only two plugins implementing this are Python and Ruby, I think we can simply emit a warning from
get-version-from-legacy-file for a while, and remove it later, but we definitely need to work on a release process.

from asdf.

@tuvistavie I think it's safe to assume that asdf should recessively search for both legacy files as and .tool-version files.

I'm currently working on a project with a .ruby-version file and I wouldn't want asdf to switch when I cd into a subdirectories.

from asdf.