Comments (5)
Closing this issue since all the PRs have been merged and are now in the latest release. Thanks for all the great work @rockwood !
from asdf.
I added the legacy file support and I agree with everything here. The less work the plugins have to do the better. I might be able to create a pull request sometime this week.
Do you happen to know which plugins include get-version-from-legacy-file
? I think I only added it to the Ruby plugin. If it's not widely used we might be able to get away with just dropping support for it.
@HashNuke @tuvistavie any thoughts on this? What do think about tagging a release before making these changes? Might save us some headaches in the future...
from asdf.
I believe these are the only plugins currently supporting the legacy file feature:
I agree that we should solidify a release process(#70) before making any changes.
from asdf.
Sorry for the late reply, and thanks for the great proposal!
Is it safe to assume that all plugins will want to start from the current directory and search the parent directory until it finds the needed file? I am not aware of any version manager which does not respect this behavior, but just to be sure.
I think @rockwood proposal is a great improvement over the current API, and I think we should move to it before other plugins start implementing the legacy file feature.
If the only two plugins implementing this are Python and Ruby, I think we can simply emit a warning from
get-version-from-legacy-file
for a while, and remove it later, but we definitely need to work on a release process.
from asdf.
@tuvistavie I think it's safe to assume that asdf should recessively search for both legacy files as and .tool-version files.
I'm currently working on a project with a .ruby-version
file and I wouldn't want asdf to switch when I cd into a subdirectories.
from asdf.
Related Issues (20)
- bug: Sporadic X Plugin Not Installed Errors - ASDF Install
- bug: `No version is set for command shasum` on Mac
- Support version requirements in tool-versions
- bug: ASDF_DEFAULT_TOOL_VERSIONS_FILENAME env variable works so wired HOT 1
- Add command line flag that prevents `asdf install` from ascending to parent directories
- bug: AUR package wants to use python but does not find any preset version
- bug: ASDF_DEBUG: unbound variable HOT 1
- bug: No times executable found for ruby 3.3.0 HOT 3
- Install should have `--local` and `--global` optional flags HOT 1
- Completion that supports split subcommands(plugin-add -> plugin add)
- Better version management HOT 1
- bug: always_keep_download has a wrong warning logic HOT 2
- Print a line mentioning what plugin/version is currently being installed
- bug: Bug Report: Unable to List Elixir Versions in ASDF HOT 2
- can we have windos? HOT 2
- Ability to explicitly set ASDF_GLOBAL_TOOL_VERSIONS_PATH
- Broken link to `ASDF_CONFIG_FILE ` environment variable
- [Feature Request] Support multiple global version files
- [Feature Request] Separate "restrict to version X" and "install version X" functionalities
- bug: python installation fails on linux mint 22 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from asdf.