Comments (8)
@vince-stark Thanks again for taking an interest in helping out the project. I am always accepting of contributions to make this library better.
from drf-tracking.
@avelis I think this one is fixed (if I check the PR which contains the commit #54 )
from drf-tracking.
@bkovacev Thanks for writing in. It looks like this an interesting fallout of two PR's 210511e & ab25cb7.
One adds error tracking and the other is to gracefully handle APIRequestLog
saving failures. In your scenario when the handle_exception
method get's called and assumes the log instance is attached to the request object. That clearly isn't the case.
Quite the bug. I don't have an immediate solution other than determining that why the APIRequestLog isn't saving during the mixins initial method. I would need to write up a test and come up with a solution to gracefully handle this scenario in handle_exception
method if no log instance exist.
Also open to a PR if you have the time to address this. Will look into this sometime by next week.
from drf-tracking.
Thank you for the reply! Let me see what I can do about it this weekend 👍 I'll keep you posted!
from drf-tracking.
This bug is also important for another reason - when a logged in user session expires, it triggers the same error, instead of following DRF's authentication scheme, and returning 403 where needed.
So, @bkovacev @avelis any updates? I can help!
from drf-tracking.
@vince-stark I will say I am a little pressed for time to come up with a change to fix this. If you have the time, the issue I believe is the side effect of a failed initialized log (with a return statement) and the handle_exception
is called and no log attribute exists on the request object. This is the scenario that needs a unit test & fix.
from drf-tracking.
@avelis sounds good - I'll work on it 👍
from drf-tracking.
This issue should be addressed in v1.3.1
from drf-tracking.
Related Issues (20)
- Log Construction HOT 1
- LogginMixin not gets called with ModelViewSet in Django 2.0.4 HOT 3
- Migrations conflict HOT 4
- When I get an api and there will always be 2 logs at a time HOT 1
- How to do drf tracking write in async thread HOT 1
- django 2 compatible HOT 3
- Can we track django-oauth-toolkit client?
- Failed Clean data when uploading file as form-data HOT 2
- Only last params value is captured if multiple query params are sent with same key
- why this line is needed? HOT 4
- UnicodeDecodeError on python 2.7 / django 1.11 HOT 2
- Feature Request: Skip logging the response HOT 1
- PIP (pypi) is not updated HOT 5
- Add city & country data to the log HOT 1
- Some requests are not recorded HOT 2
- requested_at and remote_addr fields in base_model are not null HOT 1
- Fix missing query_params on Put/Post/Patch requests. Update tox tests to include django 2.2.6 and drf 3.10.3 versions HOT 5
- Can we publish a new release? HOT 14
- Azure proxy config throws psycopg2 exception HOT 6
- Django version 3.x has not "django.utils.six" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from drf-tracking.