AttributeError: 'Request' object has no attribute 'log' on TestCase about drf-tracking HOT 8 CLOSED

@vince-stark Thanks again for taking an interest in helping out the project. I am always accepting of contributions to make this library better.

from drf-tracking.

@avelis I think this one is fixed (if I check the PR which contains the commit #54 )

from drf-tracking.

@bkovacev Thanks for writing in. It looks like this an interesting fallout of two PR's 210511e & ab25cb7.

One adds error tracking and the other is to gracefully handle APIRequestLog saving failures. In your scenario when the handle_exception method get's called and assumes the log instance is attached to the request object. That clearly isn't the case.

Quite the bug. I don't have an immediate solution other than determining that why the APIRequestLog isn't saving during the mixins initial method. I would need to write up a test and come up with a solution to gracefully handle this scenario in handle_exception method if no log instance exist.

Also open to a PR if you have the time to address this. Will look into this sometime by next week.

from drf-tracking.

Thank you for the reply! Let me see what I can do about it this weekend 👍 I'll keep you posted!

from drf-tracking.

This bug is also important for another reason - when a logged in user session expires, it triggers the same error, instead of following DRF's authentication scheme, and returning 403 where needed.

So, @bkovacev @avelis any updates? I can help!

from drf-tracking.

@vince-stark I will say I am a little pressed for time to come up with a change to fix this. If you have the time, the issue I believe is the side effect of a failed initialized log (with a return statement) and the handle_exception is called and no log attribute exists on the request object. This is the scenario that needs a unit test & fix.

from drf-tracking.

@avelis sounds good - I'll work on it 👍

from drf-tracking.

This issue should be addressed in v1.3.1

from drf-tracking.