Segfault when creating and closing lots of subprocesses about cpp-subprocess HOT 3 OPEN

Will take a look at this. Thanks for reporting.

from cpp-subprocess.

seems like everything works normal.
g++ (Arch Linux 9.2.1+20200130-2) 9.2.1 20200130

from cpp-subprocess.

I think the issue still exists. My program segfaults as well.

The error shows up, when a new file_ptr is supposed to be opened here:

I have adjusted this line, to check the error and it shows that too many files are opened and segfaults in the following read_atmost_n line, since the file could not be opened

auto file_ptr = fdopen(err_rd_pipe, "r");

if (file_ptr == NULL)
{
    printf("Oh dear, something went wrong with read()! %s\n", strerror(errno));
}

The file descriptors do not show up in lsof, as observed above.

I have noticed a difference between the usage of the reset function for the std::shared_ptr<FILE>

I think in the case below, the filepointer is actually not properly closed and the deleted file descriptor still counts against the limit.

I am not sure if this needs to be adjusted and if I understand the std API correctly.

from cpp-subprocess.