I can send() but I have no way of closing the input channel about cpp-subprocess HOT 8 CLOSED

yeah it works greatly thanks for this beautiful project.
Happy new year.

from cpp-subprocess.

#include <subprocess.hpp>

using namespace std;

using namespace subprocess;

int main()
{
	auto p = Popen({"cat", "-"}, input{PIPE}, output{"cat_fredirect.txt"});
	auto msg = "through stdin to stdout";
	p.send(msg, strlen(msg));
	p.wait();
}

i tried the code in the readme.md and it still waits forever. Haalp!

from cpp-subprocess.

I made detail::Streams stream_ public
and reset() it after send() and it worked!

	for ( int i = 0 ; i < 5 ; i++ )
	{
		sub_processes.emplace_back(Popen({"cat", "-"},input{PIPE}));
		sub_processes[i].send("3 5\n", 5);
		sub_processes[i].stream_.input_.reset();
	}

from cpp-subprocess.

Hi @mohamedAlaaK

You didn't have to make "stream_" public for this.
You could have instead done:

fclose(sub_processes[i].input());

from cpp-subprocess.

Hi @arun11299
first of all nice profile picture :D
secondly, i used that line instead of resetting the shared ptr and it did crash the program.
after going out of scope the default constructor was called and it tried to delete the shared ptr which was already deleted as a raw ptr using fclose().
is there something i am missing here?

from cpp-subprocess.

Ah..ofcourse. I will provide an API to fix it. Thanks :)

from cpp-subprocess.

i am looking forward to that. have a nice day

from cpp-subprocess.

I have added this test.

  void test_cat_send_terminate()
  {
    std::cout << "Test::test_cat_send_terminate" << std::endl;
    std::vector<sp::Popen> pops;

    for (int i=0; i < 5; i++) {
      pops.emplace_back(sp::Popen({"cat", "-"}, sp::input{sp::PIPE}));
      pops[i].send("3 5\n", 5);
      pops[i].close_input();
    }

    for (int i=0; i < 5; i++) {
      pops[i].wait();
    }

    std::cout << "END_TEST" << std::endl;
  }

Let me know if it works for you.

And, Happy new year!!

from cpp-subprocess.