Comments (6)
We're experimenting with ways to reuse the CSS for components in elan within reaction-force using a library like css-modules. However, it may make more sense to copy the styles directly into react components and just use styled-components.
I would prefer porting to the latter, because something like css-modules won’t work for if we’d ever want to share components between web and emission. Not that that’s definitely something we’ll be doing, but in order to know if it is a possibility we should try out the technologies that would be able to run on both platforms. (styled-components has RN support).
from reaction.
@alloy Right, that's a good point. Alright, question answered then. We can stick to styled-components and copy styles as appropriate.
cc @xtina-starr
from reaction.
It would be interesting to know by the end roughly how much of styling had to be ported.
from reaction.
Generally speaking, styles and components should be decoupled otherwise we wouldn't be able to use any of it in a static website. I'm still learning about React native, but there must be a way to share decoupled styles even with React Native.
from reaction.
@yuki24 That's actually not necessarily true in the age of components and css modules. To better grasp the design decisions and concepts behind CSS-in-JS. Check out the following talks. It helped me better understand why on you would embed css in your components.
React: CSS in JS
The case for CSS modules - Mark Dalgleish
from reaction.
Closing this since we have these base components done! We still have a few pieces for the loyalty page, but those are their own issues.
from reaction.
Related Issues (20)
- Jest test regex could be optimized HOT 1
- Effective responsiveness HOT 45
- New Tracking Patterns HOT 20
- Input fields lose focus after each keypress
- [RFC] Add renovate to automatically create prs for Artsy dependency updates HOT 1
- Line-height is extremely large on a few elements after responsive typography update HOT 5
- The automated release is failing 🚨 HOT 1
- State of testing Relay powered components HOT 9
- Don't publish storybook stories to npm HOT 3
- [RFC] Split reaction into multiple bundles HOT 22
- Instructions on migrating Components from Reaction to Palette HOT 2
- Initial QA for new search bar HOT 3
- Eliminate remaining SVGs HOT 4
- [RFC] New Dependency: Use Flickity instead of Slick HOT 2
- Dependency Dashboard
- [RFC] Replace Moment and Moment-Timezone in Reaction and Palette HOT 22
- Pretty text at the top got broke HOT 1
- Can I use components for third-party projects? HOT 1
- 404 on demo website
- Adopt inclusive language
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reaction.