Component List about reaction HOT 6 CLOSED

We're experimenting with ways to reuse the CSS for components in elan within reaction-force using a library like css-modules. However, it may make more sense to copy the styles directly into react components and just use styled-components.

I would prefer porting to the latter, because something like css-modules won’t work for if we’d ever want to share components between web and emission. Not that that’s definitely something we’ll be doing, but in order to know if it is a possibility we should try out the technologies that would be able to run on both platforms. (styled-components has RN support).

from reaction.

@alloy Right, that's a good point. Alright, question answered then. We can stick to styled-components and copy styles as appropriate.

cc @xtina-starr

from reaction.

It would be interesting to know by the end roughly how much of styling had to be ported.

from reaction.

Generally speaking, styles and components should be decoupled otherwise we wouldn't be able to use any of it in a static website. I'm still learning about React native, but there must be a way to share decoupled styles even with React Native.

from reaction.

@yuki24 That's actually not necessarily true in the age of components and css modules. To better grasp the design decisions and concepts behind CSS-in-JS. Check out the following talks. It helped me better understand why on you would embed css in your components.

React: CSS in JS
The case for CSS modules - Mark Dalgleish

from reaction.

Closing this since we have these base components done! We still have a few pieces for the loyalty page, but those are their own issues.

from reaction.