[deploySummary] Move out of Peril, into Horizon about peril-settings HOT 2 CLOSED

I don't understand the comment disappearance--that seems like a bug.

One way this summary aligns with Peril is that Peril already has to reevaluate PRs on every change. The set of PRs included in a release can grow as more merges and builds happen, so it works nicely that Peril can re-run and update its comment.

If you did want to add a list of PRs into the release via Horizon the DeployService is probably where you'd do it. Happy to talk more about a strategy for that.

from peril-settings.

Coming back to this, so far Peril has been solid, except for the disappearing comment after merge. That's less of an issue though.

There's also some benefit to having the infrastructure to already receive web hooks when things change. Having the initial comment contain the list of PR's generated by Horizon is fine but not realistic for deploy PR's that sit open for a while.

Then, adding specific logic to check + update a deploy PR summary in Horizon during it's cron run, is ok-ish, but starts to feel weirder.

I'll close this for now!

from peril-settings.