Comments (4)
claytondaley
commented on June 16, 2024
If there isn't another way to indicate that instances of these classes are not links, the obvious place to fix the issue is here. SlugRelatedField is a RelatedField, but not all RelatedFields are necessarily linkable URIs.
from drf-hal-json.
claytondaley
commented on June 16, 2024
If you agree in principle, I need some guidance before I can submit a PR. I'm not clear which fields can/should be completely removed from the check, which fields (e.g. HalHyperlinkedRelatedField and HalHyperlinkedIdentityField) need to be included once their ancestors are removed, and which need new Hal-derived variants.
I suspect this change won't need new tests because the existing tests for non-Hal-derived objects can simply be converted to cover the new Hal-derived ones.
from drf-hal-json.
webjunkie
commented on June 16, 2024
Duplicate of #22
from drf-hal-json.
webjunkie
commented on June 16, 2024
@claytondaley What could help is if you might update the test cases and provide one that fails for this issue here.
from drf-hal-json.
Related Issues (20)
- Non-Model HalSerializer HOT 2
- Include BrowsableAPIRenderer in Example code
- Use backwards compatible super() calls HOT 2
- drf-nested-routers interoperability HOT 1
- Add an explicit "self" field in HalModelSerializer? HOT 2
- Pagination links when there is only one page HOT 1
- SlugRelatedField gets put into links HOT 1
- Add template to pagination for clients to generate pages HOT 2
- Handling a HalContributeToLinkField that returns None
- `self` and query parameters
- rel naming
- Unpacking generalization has been introduced in python 3.5 HOT 1
- Split this fork off HOT 3
- Detached Fork HOT 3
- HyperlinkedRelatedField with None
- HyperlinkRelated Query Params HOT 1
- Link vs. Link Contribution vs. Embedded HOT 1
- Adding semantically meaningful `_links` to a Collection endpoint
- Asymmetric Serialization HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from drf-hal-json.