Suggestion: Add (optional) librtmp support about ffmpeg-kit HOT 3 CLOSED

Wouldn't be better if this was fixed on ffmpeg codebase? There is a potential solution posted on that ticket. But that solution changes a file used by other secure protocols as well. And the author of the fix does not explain why only RTMPS is affected from this bug. That ticket is created 4 years ago. It is hard to believe that no one noticed this before.

Additionally, you've said changing the files mentioned in the ticket fixed the issue in your tests. I don't get that. The ticket mentions changing tls_schannel.c and tls_securetransport.c. But both of them are not enabled in ffmpeg-kit. Editing those files shouldn't have changed anything.

from ffmpeg-kit.

Sorry, the fix in the first comment is what I was referring to, which is at rtmpproto.c:3031. My suggestion (since I know this is an underlying FFmpeg issue) was to perhaps allow the ability to configure ffmpeg-kit with an additional --enable-librtmp argument to pass along to FFmpeg's pkg-config.

There are 2 options for RTMP support, and from what I gather, librtmp (the library extracted from rtmpdump) is no longer actively developed, whereas FFmpeg's inbuilt RTMP supposedly is. There still seems to be certain edge-cases not handled correctly, such as this one, where servers might not 100% confirm to the spec, and where librtmp doesn't seem to falter.

Facebook Live forced RTMPS support after that ticket was originally created (deprecated May 2019), so perhaps fewer people were affected. I can't say why others may not have reported, but different SSL libs could also have potentially resolved this. There's been a few threads on the OBS forums related to it over the past couple of years. Some other multi-streaming platforms like dacast also seemingly require compiling FFmpeg with --enable-librtmp too.

Edit: I've adjusted the title accordingly.

from ffmpeg-kit.

I've considered supporting librtmp long time ago but decided against it because it wasn't maintained anymore as you've said.

I'll mark this issue as enhancement request. I don't know if it is possible to build librtmp for mobile platforms. It must be worked on.

from ffmpeg-kit.