The fake new first issue about first-issues HOT 19 CLOSED

@wagnernegrao Good catch.
I think before posting it on twitter, checking the issue date will be a good option to fix this.
Any thoughts?

from first-issues.

No, I also think will be a good option to fix this.

from first-issues.

Feel free to send a PR for this if you like

from first-issues.

@arshadkazmi42 has funded $5.00 to this issue.

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

from first-issues.

Hi @arshadkazmi42 I would like to take a shot at resolving this. Just making sure I have the problem understood:

Would you like the first issue bot to see when the initial issue was created to see if it is posting a repeat?

from first-issues.

@senatormailman Yes. Thats Correct. I think it will be a bit difficult to check for duplicate.
I think we just want to check the issue status, if the issue is open or not.
If the issue is closed we don't want to post it on twitter.
For now I think this would be fine.
Let me know you if have any other thoughts or suggestions for this.

from first-issues.

can take this up?

from first-issues.

@isaac-philip Sure. Go ahead.

from first-issues.

Is this still open?

from first-issues.

@isaac-philip are you still working on this? Or @therajdeepbiswas could take it up.

from first-issues.

Yes please go ahead.

Apologies for the delay to respond.

from first-issues.

@arshadkazmi42 from this conversation, what I understand of the requirement is: if the issue is a good first issue and it is open, only then add it to the database. Is my understanding correct?

from first-issues.

I have observed in first_timers.py that an issue's is:open is accounted for. I am a little confused about the problem at hand; it's observed that db.json is updated from scratch (not appended) everytime run.py is executed. Hence it is expected that the twitter bot might post the same issue more than once (provided if the updated json contains the same issue but is still open).

So what is our desired behavior now? If the same issue still continues to be open, is it okay to post it again? If that is so, this is how your (present) code already works.

If not, our other option is to never post the same issue twice (even if it is open); one way to handle this would be to keep track of every issue that has ever been posted.

The above will require us to maintain another json (or other form of) database to keep track of. Let me know what sounds good to you or if there is something more which you'd like to add to this.

from first-issues.

@therajdeepbiswas I know its difficult to track the duplicate. So I thought lets just add a check to post the issue only if its open

I am don't remember exactly if the check is already present. If its already present, I don't think we can do much about it.

For handling duplicates, I don't think we should over engineer things, since the bot does not uses any database, its going to be a complex task.

I also had a thought around this for just adding a check for how old the issue is. How about checking the date of creation of the issue and if its older than 15 days, lets not tweet that. So we will have only fresh issues posted with that the check for the issue should not be in closed state.

Any thoughts on this?

from first-issues.

@arshadkazmi42 Yes, your code does check for is:open, you've passed that in with your API call (first_timers.py: line 10), so we already have that taken care of.
Checking the age of the issue sounds good to me. (Question) How often does your bot post on twitter (if there is an active one)? Let's say we synchronize the 15 days, which you mention, with the bot. The bot will only post once every 15 days and when it does, it will only be issues created in (the same) last 15 days, and repeat. That way we won't miss anything and also prevent duplicates, I believe.

Just a note; I agree that managing a database of historical IDs (even if in a simple text file) would require to overengineer things between fetching the json and selectively saving it into a file, so let's not do that.

I'll create a PR once I have a confirmation from your end if the former mentioned thing is what you'd like to go with.

from first-issues.

@therajdeepbiswas The bot runs every 1 minute and tweets all the issues it has found with the label. Since if we have long delays for running of bot it will tweet alot of tweets in one go and twitter blocks those type of accounts. So we run it every 1 minute to minimize the number of tweets in one go.

Just having 15 days check for now should be good enough. Also, lets keep this day easily configurable so if we want to change it later we will be able to do it easily.

from first-issues.

@arshadkazmi42 I have opened PR #61. Do take a look

from first-issues.

@therajdeepbiswas Thank you for the PR. I will have look at it ASAP.

from first-issues.

@arshadkazmi42 has rewarded $3.50 to @therajdeepbiswas. See it on IssueHunt

• 💰 Total deposit: $5.00
• 🎉 Repository reward(20%): $1.00
• 🔧 Service fee(10%): $0.50

from first-issues.