Comments (6)
I'll take a look at the JS and see if I can get it to remain in the right spot. I think the behaviour you're looking for makes sense and should be the default.
from bootstrap-scroll-modal.
I changed the code
$('html').css({ 'overflow' : 'hidden' })
to
$('.container').css({ 'overflow' : 'hidden' })
and it seems to work in both chrome and firefox.
from bootstrap-scroll-modal.
Hmm. Ok, I'll look into how to best integrate that in then, as '.container' will not always be available to people using this. They may choose to not use Bootstrap's grid system and thus, not have that element.
I originally placed the overflow hidden on the body, rather than html, but overflow hidden on the body is not supported in IE6 and 7. Then again, who cares about IE! Haha. I may just revert back to placing the overflow hidden style on the body.
from bootstrap-scroll-modal.
Ah, yes, good point. I can't think of a more elegant solution at the moment.
Btw, I just want to thank you for this project. It's a huge improvement over the default bootstrap modal.
from bootstrap-scroll-modal.
I don't think it should be a hard fix, look for an update here shortly (although it seems like you have one now anyway). And thanks! I figured lots of people need dynamic height modals, so why not make it an option? I'm trying to get this code merged back into Bootstrap, so if all goes well it'll be in Bootstrap master soon enough.
from bootstrap-scroll-modal.
I've updated the JS to set the overflow property on the body rather than html. I haven't been able to find a fix for this that isn't super dirty and I really don't give a shit about IE6 or 7.
Thanks again for pointing this one out!
from bootstrap-scroll-modal.
Related Issues (20)
- iframe content clipped HOT 3
- Why overflow: auto vs. overflow: visible on removeBackdrop()? HOT 2
- 'hidden' event handlers not executing HOT 5
- when a modal opens up a second modal, original background scroll behavior is back HOT 1
- Responsive part for .modal-wrapper missing HOT 1
- Modal wrap not closing completely
- Problems with special characters HOT 1
- Problems with Internet Explorer
- CSS suggestions
- Modal flashes visible on page load HOT 3
- Merging with BootstrapModal HOT 1
- IE8 Form Fields in Modal don't work HOT 3
- Escape doesn't close modal
- Modal content displayed after closing
- Does not work with Jquery UI datetime picker
- Issue with using keyboard navigation keys
- Modal Open HOT 1
- CKEditor compatibility issue
- custom show event not firing
- Issues with always on top HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bootstrap-scroll-modal.