events_tutorial.md does printf() in ISR, this does not work about mbed-os-5-docs HOT 11 CLOSED

@AnotherButler I'll try and do it next week.

from mbed-os-5-docs.

@janjongboom I wrote this based on a combination of old forum issues, blog posts and comments. It's not a new page, and the content I used to create it was even older, so I'm not surprised it's out of date now. Please feel free to update it to make it technically correct or to let me know exactly how to change it to make it correct. Thanks for catching it 👍

from mbed-os-5-docs.

@janjongboom There is a PR up to improve this document: #349

Does it solve this issue?

from mbed-os-5-docs.

@AnotherButler, no that's about other documents (same subject, different document). Maybe we should change the current tutorial to https://os.mbed.com/blog/entry/Simplify-your-code-with-mbed-events/, it does not suffer from the same problem.

from mbed-os-5-docs.

@janjongboom Because there is additional content on that page that is still correct, I don't want to replace the whole page. I understand how busy you are, but when you get the chance, could you please help me update the examples and other text in the tutorial that's incorrect? Or could you recommend an engineer who could? Thanks so much.

from mbed-os-5-docs.

@janjongboom Because there is additional content on that page that is still correct, I don't want to replace the whole page. I understand how busy you are, but when you get the chance, could you please help me update the examples and other text in the tutorial that's incorrect? Or could you recommend an engineer who could? Thanks so much.

Update example referenced above, please review

from mbed-os-5-docs.

Since printf() was removed from rise_handler(), the output at the bottom of the source code is inconsistent. It shouldn't show the line "rise_handler in context 0x0".

from mbed-os-5-docs.

@coisme Good point. I believe what we can do is fix the example by using RawSerial and print what was previously there to see the difference between contexts. but having printf in ISR is a "bad idea".

from mbed-os-5-docs.

@janjongboom Do @0xc0170 's updates solve this issue?

from mbed-os-5-docs.

@janjongboom Do @0xc0170 's updates solve this issue?

from mbed-os-5-docs.

I believe it should and this shall be closed. reopened if there is still a problem

from mbed-os-5-docs.