Code Monkey home page Code Monkey logo

Comments (23)

netanelgonen avatar netanelgonen commented on August 20, 2024

Hi @JanneKiiskila can you please take a look at this issue.

from easy-connect.

teetak01 avatar teetak01 commented on August 20, 2024

@netanelgonen there was a bug in one of the drivers that caused compilation to fail. It has been merged in now #88

What you are otherwise asking, would require that every single driver would wrap their code in some Mbed OS and driver-specific compilation flag. We did this for the Mesh-drivers as those had some complicated dependencies. You can suggest such changes to the owners of the other drivers.

from easy-connect.

JanneKiiskila avatar JanneKiiskila commented on August 20, 2024

Please put in the logs for the compilation errors here and raise issue to the respective non-compiling driver. @netanelgonen Also, you do not need to delete the drivers - you can use .mbedignore -files.

from easy-connect.

netanelgonen avatar netanelgonen commented on August 20, 2024

Hi @teetak01 ,
you can put the drivers under the folder 'TARGET_*'
this way the driver will compile only if the target is relevant.
see example in https://github.com/ARMmbed/mbed-client-pal/tree/master/Configs/pal_config/mbedOS

@JanneKiiskila deleting the files was a fast workaround just like adding the .medignore file
in the current situation that we are trying to save the binary size of the application, we should not compile extra files that contain global variables and definitions. specially not cpp constructors

from easy-connect.

teetak01 avatar teetak01 commented on August 20, 2024

@netanelgonen you misunderstood, most of those drivers are owned by partners. We cannot make any codechanges, and so far there is no urgent need for that.

@netanelgonen open issue to the respective driver repository if you think there is some problems. Otherwise there should be no impact. Note that easy-connect really is EASY connect. Its for simple usage of multiple drivers.

from easy-connect.

netanelgonen avatar netanelgonen commented on August 20, 2024

@teetak01 actually I understood perfectly.
I understand that the driver repository cannot be changed, but their location should change.
the location of each driver should be under a folder named 'TARGET_*' in this way the driver will compile only for this target. if you need a femily of targets you can always use the parent of the target.

have you looked in the exmaple from mbed-client-pal?
this will not chane the 'easy' of the code it will just save space and reduce the option for errors.

from easy-connect.

JanneKiiskila avatar JanneKiiskila commented on August 20, 2024

Well, for any of the external Wi-Fi boards for example - you can connect them to pretty much any board, what would be the right TARGET_ then?

from easy-connect.

netanelgonen avatar netanelgonen commented on August 20, 2024

is esp8266-driver is relevent for all board?
and wifi-ism43362?
or wifi-x-nucleo-idw01m1?

those are for specifec board targets (as far as i understeand)

from easy-connect.

JanneKiiskila avatar JanneKiiskila commented on August 20, 2024

Those use serial for connection, so you can connect them to pretty much anything.
For WiFi-X, there's even 2 form factors - Arduino and Morpheus to suit different boards (driver is anyway the same, config just changes a tad).

from easy-connect.

netanelgonen avatar netanelgonen commented on August 20, 2024

Hi @JanneKiiskila so what you are actually writing here that all driver is needed to all mbed-os targets?

from easy-connect.

teetak01 avatar teetak01 commented on August 20, 2024

We do not actually know exactly which targets need which driver.

from easy-connect.

netanelgonen avatar netanelgonen commented on August 20, 2024

so maybe enable the drivers only when knowing that there are needed for the target?

from easy-connect.

JanneKiiskila avatar JanneKiiskila commented on August 20, 2024

Yes, the WiFi modules are all universal, they should work with pretty much any board you can throw them at.

from easy-connect.

netanelgonen avatar netanelgonen commented on August 20, 2024

So @JanneKiiskila you think this is better to compile unneeded drivers and their constructors and so on just for the possibility that you will want one of those drivers is the way to go?

from easy-connect.

JanneKiiskila avatar JanneKiiskila commented on August 20, 2024

Currently there is no mechanism for that, however. One should be invented. The drivers need to be usable even w/o easy-connect itself.

from easy-connect.

teetak01 avatar teetak01 commented on August 20, 2024

Well, actual production application probably will not pull in easy-connect, and will instead use Mbed OS API directly. This is really easy-of-use wrapper library. If you do not care about the other drivers, just remove easy-connect completely. With Odin board especially, it does not need this for anything.

from easy-connect.

JanneKiiskila avatar JanneKiiskila commented on August 20, 2024

Yes, indeed - if the example is targeting only ONE board with ONE connectivity, there is really no need to use easy-connect.

from easy-connect.

netanelgonen avatar netanelgonen commented on August 20, 2024

so every one that use the appliaction need to delete this repo unless he useses a specific target?

from easy-connect.

teetak01 avatar teetak01 commented on August 20, 2024

No, this is part of mbed-cloud-client-example and mbed-os-example-client. Both compile out-of-box without any changes. What issue you had was some more specific.

from easy-connect.

netanelgonen avatar netanelgonen commented on August 20, 2024

actually, I'm the not specific user.
I'm trying to add new modules.....

from easy-connect.

JanneKiiskila avatar JanneKiiskila commented on August 20, 2024

Well, if stuff now works out of the box as is - and then doesn't, then it sounds more like the new driver might be having the problem.

from easy-connect.

netanelgonen avatar netanelgonen commented on August 20, 2024

I'm using the mbed-os Odin driver...

from easy-connect.

netanelgonen avatar netanelgonen commented on August 20, 2024

Hi @avolinski this is the issue we talked about

from easy-connect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.