logging broken about binaryanalysis-ng HOT 5 CLOSED

@timhemel when I print the value of uselogging in log() it says "None". Probably scoping?

from binaryanalysis-ng.

It is better to pass the logger and with it uselogging, as parameters to each process. This prevents that garbage collection in the parent process affects the other processes or something along those lines. But even better is to have each process log to its own file, this prevents the logfile being a bottleneck, and makes it easier to see what happens in each thread.

from binaryanalysis-ng.

perhaps rework according to the best practices here? https://docs.python.org/3/howto/logging.html

from binaryanalysis-ng.

Yes, and reading https://docs.python.org/3/howto/logging-cookbook.html#logging-to-a-single-file-from-multiple-processes suggest that each process should log to its own file.

from binaryanalysis-ng.

Confirmed that the fix works.

from binaryanalysis-ng.