Numpy 2 compatibility about pyart HOT 14 CLOSED

@neutrinoceros It's not weird at all that pip is involved on conda-forge; lots of projects have $PYTHON -m pip install --no-deps --no-build-isolation -vv . as their canonical build step.

@mgrover1 Here's an example where the recipe for netcdf patches the source. Essentially, create a patch file (could be as easy as git diff > my.patch) and list it under sources; conda-build will take care of applying it.

from pyart.

Hey @neutrinoceros, thanks for the heads up! @mgrover1 and I will keep an eye out and will get that tested and switched over as soon as possible. Thanks again!

from pyart.

Ohhh that is a good point - I will apply the patch and see if that resolves the issue.

from pyart.

There is an issue with numpy 2.0 and cython.. described here
cython/cython#6100 (comment)

from pyart.

@neutrinoceros More of a heads up, we were able to get the numpy wheels builds going etc, but we are still trying to figure out the cause of the cython errors in the mac os feedstock builds.

from pyart.

thanks for letting me know !

from pyart.

Reopening - unfortunately we cannot support this yet @neutrinoceros as we are running into conda-forge distribution errors. Until this is tested/sorted out, we are rolling back to oldest-supported-numpy

from pyart.

Not sure I get what the problem is. My understanding is that conda-forge has its own, unrelated mechanism for dealing with numpy ABI compatibility and numpy 2.0 isn't a concern yet from the standpoint of feedstock maintainers.
xref conda-forge/conda-forge.github.io#1997

from pyart.

We are seeing numerous cython related issues
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=917141&view=logs&j=9c5ef928-2cd6-52e5-dbe6-9d173a7d951b&t=20c71c51-4b27-578b-485d-06ade2de1d00&l=1608

from pyart.

the only thing that has changed as been moving from numpy 1 to 2

from pyart.

As far as I understand, conda-forge build bots do not even read build system metadata from pyproject.toml, so I doubt this is where the problem is. However, it should be okay to apply any patch needed in that area directly in your conda-forge recipe, since building against numpy 2.0.0rc1 really just matters for PyPI wheels

from pyart.

I see that pip seems to be used in the conda-forge build process, which seems unusual (to me ?), so that might be why, but patching pyproject.toml on conda-forge should be enough to resolve the matter without loosing numpy 2 compat in PyPI wheels.

from pyart.

Do you have an example of applying patches to conda-forge recipes?

from pyart.

Great - thanks @dopplershift !!

from pyart.