Code Monkey home page Code Monkey logo

Comments (9)

stcarrez avatar stcarrez commented on August 21, 2024

Yes, that could be a nice idea!

from argouml.

vincenzopalazzo avatar vincenzopalazzo commented on August 21, 2024

Hi @stcarrez,

Thanks, I will work on the library official release and I will start the work on the ArgoUML l&f integration.

from argouml.

linustolke avatar linustolke commented on August 21, 2024

Contributions are welcome. We don't use Pull Requests but instead use repo/Gerrithub.

from argouml.

vincenzopalazzo avatar vincenzopalazzo commented on August 21, 2024

Hi @linustolke,

Thank you. Yes, I wrote PR I'm sorry, but I wanted mean to submit my change in repo/Gerrithub.

from argouml.

vincenzopalazzo avatar vincenzopalazzo commented on August 21, 2024

Hi @linustolke and @stcarrez,

I was starting to work to test material-ui-swing library on ArgoUML and I have a demo version, with incomplete code, but I want share the code with the team because it knows the code better than me and I think that I can receiver good feedbacks about improving the code.

I don't know gerrithub and I don't know what happens if I push my actual version of code on my branch, it remains on my branch or the push start the auto review process??

Thanks for your time.

P.S: another screenshot of the style is in the photo below, and also exist this issue yet

from argouml.

stcarrez avatar stcarrez commented on August 21, 2024

I'm interested to try your version (either from your own git repo or from a repo branch).

Is it possible to increase the font size in your implementation?
Having bigger text and bigger icons is something I'm really interested in because I have problems when
using the current ArgoUML.

Have a look at https://github.com/argouml-tigris-org/argouml/wiki/Working-in-the-project
I was able to use repo as explained, build, test and so on, but the submission with repo upload failed for me, even though I have an account on gerrit.

For the review process, @linustolke will tell you.

from argouml.

vincenzopalazzo avatar vincenzopalazzo commented on August 21, 2024

Hi @stcarrez,

I'm interested to try your version (either from your own git repo or from a repo branch).
I used repo to clone the project, but I don't know if I push my branch, it will available oonline. I don't have any github repository with the code but I can generate a build for you.

There is a few bugs on GUI, the most evident is in the toolbar with a tool to build the diagram, but at this link, there is my local version.

Having bigger text and bigger icons is something I'm really interested in because I have problems when
using the current ArgoUML.

I think that the problem with the font is resolved also with metal theme? (maybe) but I think that with L&F is possible to change the font size but I don't know if is possible to make the change with image size, because I don't know the format (png/jpg) of these images.

from argouml.

linustolke avatar linustolke commented on August 21, 2024

Hello @vincenzopalazzo!

The main idea with using repo/GerritHub is to get a clean line of changes on master. Every change is a single commit (not a merge commit) on master with the complete change. The upload should be a single commit that is then amended with preserved ChangeID.

If keeping your branch means that you will:

  • Upload multiple commits to GerritHub, that fixes problems back and forth, that will be cumbersome because each commit is then considered as a separate change and to keep the master change log clean I would not want to approve a commit that is soon fixed.
  • Not keep the same ChangeID between the times you upload to GerritHub, there will be a lot of confusion. Each upload will then be considered as a new change and it will not be possible to use GerritHub to trace comments, if they are fixed, and compare different uploads.

from argouml.

vincenzopalazzo avatar vincenzopalazzo commented on August 21, 2024

Hi @linustolke,

Sorry for the delay.

Thanks for the clarification about how GerritHub, and if I understand is not good to talk about the code but is good to propose a new feature or bug fix

from argouml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.