Code Monkey home page Code Monkey logo

Comments (1)

Angelin01 avatar Angelin01 commented on August 16, 2024 1

In response to: #2870 (comment)

I understand the result is OK, that is not the argument here. The result is OK because we cast all values to strings here: https://github.com/argoproj/argo-helm/blob/main/charts/argo-cd/templates/_helpers.tpl#L202

However, at the VALUES, all values were converted to bools:

configs:
  cm:
    server.rbac.log.enforce.enable: false
    exec.enabled: false
    admin.enabled: true
    statusbadge.enabled: false

Since the user may fill these in as strings, as expected by ArgoCD's documentation, the change in da00680 caused breakage.

What I am arguing is that this is unexpected. When I look at these values, I think they will map DIRECTLY to ArgoCD's CM: https://argo-cd.readthedocs.io/en/stable/operator-manual/argocd-cm-yaml/

It "looks like it does", and it in fact, it does, but we cast all values to strings. So, suddenly requiring the user to fill out a bool instead of a string is "unexpected". This caused breakage when updating (in my use case) and also the one reported in #2663.

from argo-helm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.