Comments (1)
In response to: #2870 (comment)
I understand the result is OK, that is not the argument here. The result is OK because we cast all values to strings here: https://github.com/argoproj/argo-helm/blob/main/charts/argo-cd/templates/_helpers.tpl#L202
However, at the VALUES, all values were converted to bools:
configs:
cm:
server.rbac.log.enforce.enable: false
exec.enabled: false
admin.enabled: true
statusbadge.enabled: false
Since the user may fill these in as strings, as expected by ArgoCD's documentation, the change in da00680 caused breakage.
What I am arguing is that this is unexpected. When I look at these values, I think they will map DIRECTLY to ArgoCD's CM: https://argo-cd.readthedocs.io/en/stable/operator-manual/argocd-cm-yaml/
It "looks like it does", and it in fact, it does, but we cast all values to strings. So, suddenly requiring the user to fill out a bool instead of a string is "unexpected". This caused breakage when updating (in my use case) and also the one reported in #2663.
from argo-helm.
Related Issues (20)
- full changelog diff on releases is wrong HOT 1
- Add egress NetworkPolicies HOT 1
- redisSecretInit.serviceAccount.create and redisSecretInit.serviceAccount.name have unintended behavior
- Cannot use an existingSecret for `persistence` with multiple namespaces
- 2.12 support: ApplicationSet Role cannot list resource "appprojects" in API group "argoproj.io" HOT 5
- overrideNamespace is not propagated to redis-secret HOT 1
- ApplicationSet controller fail with v1alpha1.AppProject: appprojects.argoproj.io is forbidden error HOT 1
- No source of truth for kubernetes CRD compatibility
- Possible Bug in workflow cluster role missing permissions
- User argo-rollouts cannot update deployments in API group apps in the namespace X HOT 2
- CRD upgrade found in read me doesn't work HOT 2
- Optional REDIS_PASSWORD env variable cause race condition and Redis NOAUTH failures HOT 6
- Add way to make tls secrets volumes non-optional HOT 3
- Parameter cm.url required for Dex callback when using ingress path
- ArgoCD upgrade from Helm Chart 6.7.3 to 7.3.11 fails due to argo-redis secret job HOT 5
- unexpected redis-secret-init churn
- Failed to compare desired state to live state HOT 2
- Administrator account login failure and ingress issue HOT 1
- SSH agent requested but SSH_AUTH_SOCK not-specified Error occured when upgrade version to v2.12.0 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from argo-helm.