Code Monkey home page Code Monkey logo

Comments (4)

GoogleCodeExporter avatar GoogleCodeExporter commented on May 23, 2024
Confirmed.  The issue is the double-negative on this header:
@@ --2,32 +9,36 @@
patch_fromText is absolutely correct to throw an IllegalArgumentException when 
presented with that malformed patch.

Will investigate and push a new version within a few hours.  Thank you!

Original comment by [email protected] on 24 Mar 2009 at 7:59

  • Added labels: Priority-High
  • Removed labels: Priority-Medium

from google-diff-match-patch.

GoogleCodeExporter avatar GoogleCodeExporter commented on May 23, 2024
It looks like a simple indexing failure when moving from one patch to the next. 

Affects all versions of this library.  But I want to run some exhaustive tests 
to 
make sure.  If you are in a hurry, just make the following one line patch into 
patch_make(text1, diffs).  Otherwise I'll post an update with a bunch more unit 
tests 
once I'm completely satisfied that this isn't a case of whack-a-mole.  There 
already 
is one unit test for this, but I can see now it's incorrect.

          if (!patch.diffs.isEmpty()) {
            patch_addContext(patch, prepatch_text);
            patches.add(patch);
            patch = new Patch();
            prepatch_text = postpatch_text;
            // Fixes issue #18:
            char_count1 = char_count2;
          }

Original comment by [email protected] on 25 Mar 2009 at 1:08

  • Added labels: ****
  • Removed labels: ****

from google-diff-match-patch.

GoogleCodeExporter avatar GoogleCodeExporter commented on May 23, 2024
Thanks for the update Neil - appreciate the quick response.

Original comment by [email protected] on 25 Mar 2009 at 10:46

  • Added labels: ****
  • Removed labels: ****

from google-diff-match-patch.

GoogleCodeExporter avatar GoogleCodeExporter commented on May 23, 2024
Yes, that one line change is a complete fix.  I've pushed out a new version on 
SVN 
and as a source archive which corrects all four language versions.  A new unit 
test 
has been added and an existing test has been corrected.

Thank you for the great bug report.

Original comment by [email protected] on 25 Mar 2009 at 6:02

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

from google-diff-match-patch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.