Equals implementation about smartenum HOT 12 CLOSED

To be safe, it might be best to compare the value.

I'm just remembering that an empty constructor was added to play nice with Entity Framework which, I believe, creates a new instance of the SmartEnum (see #15). In this case comparing by reference would be incorrect.

from smartenum.

Merged - I'll try to publish a new build to Nuget soon. Thanks!

from smartenum.

Something like TestEnum.One == myEnumVar?

Sounds like a great idea to me.

from smartenum.

I’d definitely consider a PR with this, thanks!

from smartenum.

Cool! I'll have a look at it somewhere in the next days.

@yarrgh Exactly. :)

from smartenum.

After thinking about this a bit more doesn't TestEnum.One == myEnumVar already work?

Unless you're newing up objects outside of the static readonly properties, this should work. By default the framework compares the reference of objects unless explicitly overridden. Since they are pointed to the same instance of the object the equals check would run correctly.

from smartenum.

It probably should. Not sure if we have tests that demonstrate this is the case already. If not, we should at least add such tests, so there's no question.

from smartenum.

Hmm, yeah, it should be the same reference. But would it be okay then to just compare by reference, and not the actual value (in case the tests would show it does work)? In that case, it should probably also be documented in the README, as it's a quite implicit thing.

Though I'm probably already thinking ahead a little. I'll try to have a look at it and let you know about and show what I found. :)

from smartenum.

Just thought to quickly let you know I haven't further looked into it yet, sorry. But I didn't forget about it!

Also, thanks for the remarks on the EF constructor.

from smartenum.

I just created a pull request #22 that provides this feature, I hope in a good way.

For tests, I only added some that check different instances of the SmartEnum (like when using EF). Checks by reference are already done in other tests, like SmartEnumExplicitConversion.

Feel free to let me know if there are other ideas about doing this. :)

from smartenum.

I thought to quickly give a heads-up that if there's something I can do still regarding this issue / feature, feel free to let me know. Otherwise I'll just wait for feedback. :)

from smartenum.

What, a month seems like too long for me to look at this? ;)

from smartenum.