Comments (6)
pbrisbin
commented on August 16, 2024
1
The patch adds the following line,
if [[ $(pacman -Si $name | grep '@manjaro') ]]Which I suspect is where the extra output comes from:
% pacman -Si 'foo|bar'
error: package 'foo|bar' was not foundThat shell is not correct. It should probably be more like,
if pacman -Si "$name" &>dev/null | grep -Fq '@manjaro'; thenSo this seems to be a bug in the patch and unrelated to downgrade.
from downgrade.
pbrisbin
commented on August 16, 2024
1
@atreyasha the line you quoted is probably not the source because you can see it (correctly) includes 2>/dev/null and is (also correctly) checking the output instead of passing it uselessly to [[ ;)
from downgrade.
atreyasha
commented on August 16, 2024
Hi Stefano, thanks for the question.
I do not fully understand the issue. Is cram raising an error when testing or does it concern PKGBUILD when building the package?
Please provide error logs and commands that you used, so I can reproduce the error.
from downgrade.
Ste74
commented on August 16, 2024
Hi, thank you for answear.
Step for reproduce:
git clone git clone https://gitlab.manjaro.org/packages/community/manjaro-downgrade.git
cd manjaro-downgrade
git checkout github
makepkg -sr
errors:
~/manjaro-downgrade github ?1 export LANG=C && makepkg -srCcf
==> Making package: manjaro-downgrade 2.0-2 (lun 8 mag 2023, 18:27:24)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Installing missing dependencies...
resolving dependencies...
looking for conflicting packages...
Packages (1) python-cram-0.7-10
Total Installed Size: 0,17 MiB
:: Proceed with installation? [Y/n]
(1/1) checking keys in keyring [######################] 100%
(1/1) checking package integrity [######################] 100%
(1/1) loading package files [######################] 100%
(1/1) checking for file conflicts [######################] 100%
(1/1) checking available disk space [######################] 100%
:: Processing package changes...
(1/1) installing python-cram [######################] 100%
:: Running post-transaction hooks...
(1/1) Arming ConditionNeedsUpdate...
==> Retrieving sources...
-> Found downgrade-11.3.0.tar.gz
-> Found atreya.pgp
-> Found manjaro-downgrade.patch
==> Validating source files with sha256sums...
downgrade-11.3.0.tar.gz ... Passed
atreya.pgp ... Passed
manjaro-downgrade.patch ... Passed
==> Removing existing $srcdir/ directory...
==> Extracting sources...
-> Extracting downgrade-11.3.0.tar.gz with bsdtar
==> Starting prepare()...
patching file bin/downgrade
==> Removing existing $pkgdir/ directory...
==> Starting check()...
cram test
...!
--- test/main/invalid-input.t
+++ test/main/invalid-input.t.err
@@ -8,6 +8,7 @@
> printf "ignore: %s\n" "${to_ignore[@]}"
> printf "install: %s\n" "${to_install[@]}"
> printf "exit code: %s\n" "$exit_code"
+ error: package 'foo|bar' was not found
Failed to parse A.L.A.
No results found
Unable to downgrade foo|bar
.....................................
# Ran 41 tests, 0 skipped, 1 failed.
make: *** [Makefile:34: test] Error 1
==> ERROR: A failure occurred in check().
Aborting...
==> Removing installed dependencies...
checking dependencies...
Packages (1) python-cram-0.7-10
Total Removed Size: 0,17 MiB
:: Do you want to remove these packages? [Y/n]
:: Processing package changes...
(1/1) removing python-cram [######################] 100%
:: Running post-transaction hooks...
(1/1) Arming ConditionNeedsUpdate...
~/manjaro-downgrade github ?1
Sorry for the foreign characters, i use custom zsh shell.
Stefano
from downgrade.
atreyasha
commented on August 16, 2024
cram test
...!
--- test/main/invalid-input.t
+++ test/main/invalid-input.t.err
@@ -8,6 +8,7 @@
> printf "ignore: %s\n" "${to_ignore[@]}"
> printf "install: %s\n" "${to_install[@]}"
> printf "exit code: %s\n" "$exit_code"
+ error: package 'foo|bar' was not found
Failed to parse A.L.A.
No results found
Unable to downgrade foo|bar
.....................................
# Ran 41 tests, 0 skipped, 1 failed.
make: *** [Makefile:34: test] Error 1
The diff above originates from the following line throwing an error:
Line 79 in a1d9b22
error: package 'foo|bar' was not found should not be logged since we redirect stderr to /dev/null. So the problem could be with the redirection or the line being streamed to stdout instead.
Do you encounter this error when you build without the .patch files?
from downgrade.
Ste74
commented on August 16, 2024
Thank you to point me .. pacman -Si Is the guilty so Need to modify this check ..
Thank you again
Cheers
Stefano
from downgrade.
Related Issues (20)
- fzf as optional dependency HOT 4
- Use `getopts` to handle CLI arguments in lower-level scripts HOT 1
- IgnorePkg incorrectly added if IgnorePkg string is not already in config file HOT 4
- Packages with a slash in the name cannot be downgraded HOT 4
- Does not handle multile architectures in pacman.conf HOT 2
- v12 roadmap
- Downgrade somehow bricked my entire system HOT 3
- `downgrade-11.2.0-1` does not appear to build with `paru HOT 5
- Downgrade with dependencies HOT 6
- Downgrade system upgrade from pacman log HOT 3
- Option to not ask to add IgnorePkg HOT 1
- Should the default config show all options or defaults? HOT 1
- Ability to add a package to ignored regardless of the keyboard layout HOT 3
- downgrade-11.3.0-1 package doesn't include executables HOT 3
- Force Option HOT 7
- Fzf menu keymaps HOT 3
- Add documentation for AUR package downgrading HOT 4
- After some full system update, i got "error while loading shared libraries: libalpm.so.13" HOT 5
- `-- --nodeps` ignored HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from downgrade.