Express 5 heads up about celebrate HOT 7 CLOSED

Hmmm interesting. Seems like we're going to need to do some extra now to update incoming message values when Joi makes changes to the object.

Are there docs about Express 5 anywhere?

from celebrate.

I've only found this
http://expressjs.com/en/guide/migrating-5.html

Why is it that I could comment out the offending line and seemingly make it work again?

from celebrate.

Why is it that I could comment out the offending line and seemingly make it work again?

Are you referring to https://github.com/continuationlabs/celebrate/blob/a61daa15813f828515bbbedd33bea989f32b59eb/lib/index.js#L37? If so, it works because you're no longer overwriting the existing query mentioned in that error message. The problem is that it cripples the functionality of Celebrate. You will be able to validate inputs, but not update them, which is something Joi supports.

from celebrate.

Oh ok I didn't realize Joi had that 'convert' option, now it makes sense.

I vaguely remember req.params changing to read only, but I can't remember where. I can understand the argument that middleware shouldn't be modifying the input, but I think you have a stronger argument. I'm dig a little deeper into this.

from celebrate.

For context:

Here is the Express 5.0 release notes/PR: expressjs/express#2237
Here is the PR that updated req.query to be a getter: expressjs/express#2215
Here is the commit: expressjs/express@dcc4eaa

from celebrate.

If anyone is following along here, and cares enough, there is some discussion going on at expressjs/express#3472. You may want to weigh in.

from celebrate.

Closed via #48

from celebrate.