Code Monkey home page Code Monkey logo

Comments (5)

naveedn avatar naveedn commented on May 20, 2024 2

Understood, thanks for considering! Thanks again for your work.

from celebrate.

cjihrig avatar cjihrig commented on May 20, 2024

I'm not entirely sure what you're proposing here. I think we're unlikely to add or remove anything from the interface. We want to keep this as a very thin layer on top of joi. Perhaps you could post some code showing the proposed APIs you'd be adding?

from celebrate.

naveedn avatar naveedn commented on May 20, 2024

Sorry if that wasn't clear.

The library I created is a very thin layer on top of your library. All it does is provide a couple facade methods to make things easier to read.

It allows you to do stuff like:

app.get('/',
  vayder.validateHeaders(AuthenticationSchema),
  vayder.validateQuery(paginationSchema),
  vayder.validateParams(userIdSchema),
  someController.doStuff);

I was wondering if you guys wanted that functionality directly inside celebrate. Otherwise I will keep it in my repo.

Cheers

from celebrate.

cjihrig avatar cjihrig commented on May 20, 2024

I'm not sure what @arb thinks, but I think leaving the two modules/APIs separate makes sense.

from celebrate.

arb avatar arb commented on May 20, 2024

I agree with @cjihrig on this one. If you want to expose a wrapper like that, that's fine. That approach actually goes against one of the project goals of the project; being as close to hapi as reasonably possible.

from celebrate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.