Overriding Origin header in defaultSession causes Electron to crash about electron-fetch HOT 4 CLOSED

Confirmed this is still an issue in [email protected] but appears fixed in [email protected]

Here is the native stack trace from 5.0.6:
https://sentry.io/share/issue/28bad86aacec4962ac119b078b874f43/

from electron-fetch.

@timfish looking at your stacktrace (or even just the description), it appears to be a bug in electron's net module (not very surprising, I have found and reported a few of those myself.. including the one which made me switch to defaultSession by default : electron/electron#13587 ).

I suggest opening a bug report on electron's project.

You could try to work around the bug by passing another session to electron-fetch.

Sorry but there does not seem to be anything I can do on electron-fetch's side :/

from electron-fetch.

it appears to be a bug in electron's net module

Indeed it does! If it existed in 6.0.0-beta.13 I would take the time to report it upstream to Electron but as it appears to be fixed there and in the latest 7-nightly so probably not worth the effort.

@arantes555 leave this open in case anyone else encounters this?

from electron-fetch.

@timfish Yes, leaving this open for the moment, at least until 6 is released for good. Thanks for your testing !

(btw if you want to be even more thorough, or are just curious, you could try triggering the bug without electron-fetch, just doing a net request after setting onBeforeSendHeaders)

from electron-fetch.